Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 1325253002: Treat U+2028 as a special code point when escaping for JSON. (Closed)

Created:
5 years, 3 months ago by Robert Sesek
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Treat U+2028 and U+2029 as special code points when escaping for JSON. BUG=525832 Committed: https://crrev.com/7df07dcca79422e9098fd966cc3e8839af8cb912 Cr-Commit-Position: refs/heads/master@{#347722}

Patch Set 1 #

Patch Set 2 : Typo #

Patch Set 3 : U+2029 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M base/json/string_escape.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M base/json/string_escape_unittest.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Robert Sesek
5 years, 3 months ago (2015-09-04 14:44:11 UTC) #2
Lei Zhang
lgtm Do you want to check 2029 as well?
5 years, 3 months ago (2015-09-04 18:53:58 UTC) #3
Robert Sesek
On 2015/09/04 18:53:58, Lei Zhang wrote: > lgtm > > Do you want to check ...
5 years, 3 months ago (2015-09-08 14:40:00 UTC) #4
Lei Zhang
++lgtm
5 years, 3 months ago (2015-09-08 16:47:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325253002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325253002/40001
5 years, 3 months ago (2015-09-08 16:48:47 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-08 16:53:50 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 16:54:40 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7df07dcca79422e9098fd966cc3e8839af8cb912
Cr-Commit-Position: refs/heads/master@{#347722}

Powered by Google App Engine
This is Rietveld 408576698