Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 1325233005: find-releases: handle untagged merges (Closed)

Created:
5 years, 3 months ago by scottmg
Modified:
5 years, 3 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

find-releases: handle untagged merges At the moment, this doesn't work too well for something that was just merged to 45. [(b912ace...)]scottmg@scottmg:/work/cr/src$ git find-releases 55b4c95889d6a72e52bc72702580a62f04f35777 commit 55b4c95889d6a72e52bc72702580a62f04f35777 was: initially in 47.0.2501.0 merged to undefined (as de54b58d404a0cdf01639ae7260ef10bbb843ed9) merged to 46.0.2490.19 (as b4ba1071baaabc92cb5a2ca89e238c478eca0075) ("undefined" being the problem). This is because: [(b912ace...)]scottmg@scottmg:/work/cr/src$ git name-rev --tags de54b58d404a0cdf01639ae7260ef10bbb843ed9 de54b58d404a0cdf01639ae7260ef10bbb843ed9 undefined But, [(b912ace...)]scottmg@scottmg:/work/cr/src$ cat .git/refs/remotes/branch-heads/2454 de54b58d404a0cdf01639ae7260ef10bbb843ed9 So, if name-rev --tags says it's not yet tagged, rather than just printing 'undefined', at least say which branch it was merged to. As in: [(b912ace...)]scottmg@scottmg:/work/cr/src$ git find-releases 55b4c95889d6a72e52bc72702580a62f04f35777 commit 55b4c95889d6a72e52bc72702580a62f04f35777 was: initially in 47.0.2501.0 merged to branch-heads/2454 [untagged] (as de54b58d404a0cdf01639ae7260ef10bbb843ed9) merged to 46.0.2490.19 (as b4ba1071baaabc92cb5a2ca89e238c478eca0075) R=dpranke@chromium.org,primiano@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296621

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M git_find_releases.py View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
5 years, 3 months ago (2015-09-09 22:56:40 UTC) #1
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-09 23:00:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325233005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325233005/1
5 years, 3 months ago (2015-09-09 23:10:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=296621
5 years, 3 months ago (2015-09-09 23:15:38 UTC) #5
Primiano Tucci (use gerrit)
5 years, 3 months ago (2015-09-09 23:16:44 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698