Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 132523006: [NaCl SDK] Make ARM cross compiler optional until trybots get updated. (Closed)

Created:
6 years, 11 months ago by Sam Clegg
Modified:
6 years, 11 months ago
Reviewers:
binji
CC:
chromium-reviews, binji
Visibility:
Public.

Description

[NaCl SDK] Make ARM cross compiler optional until trybots get updated. This change, combined with the recent revert of the SDK ARM components on in the NaCl tree (https://codereview.chromium.org/141733005/) should allow the SDK builders to go green again. BUG=335303 R=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246461

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +9 lines, -6 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
6 years, 11 months ago (2014-01-22 22:27:30 UTC) #1
binji
lgtm, w/ question https://codereview.chromium.org/132523006/diff/1/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): https://codereview.chromium.org/132523006/diff/1/native_client_sdk/src/build_tools/build_sdk.py#newcode540 native_client_sdk/src/build_tools/build_sdk.py:540: if os.path.exists("/usr/bin/arm-linux-gnueabihf-gcc"): shouldn't this just skip ...
6 years, 11 months ago (2014-01-22 22:33:46 UTC) #2
Sam Clegg
https://codereview.chromium.org/132523006/diff/1/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): https://codereview.chromium.org/132523006/diff/1/native_client_sdk/src/build_tools/build_sdk.py#newcode540 native_client_sdk/src/build_tools/build_sdk.py:540: if os.path.exists("/usr/bin/arm-linux-gnueabihf-gcc"): On 2014/01/22 22:33:47, binji wrote: > shouldn't ...
6 years, 11 months ago (2014-01-22 22:36:04 UTC) #3
Sam Clegg
6 years, 11 months ago (2014-01-23 00:58:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r246461 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698