chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java - Issue 1325213002: customtabs: UMA histogram tracking whether clients call warmup().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

Issue 1325213002: customtabs: UMA histogram tracking whether clients call warmup(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/ClientManager.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/ClientManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

index 0538232d2652d9d2d66cad1e0156528347de2386..283b4c548036f6e415a335e14009f38df5b863ee 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

@@ -132,6 +132,7 @@ public class CustomTabsConnection extends ICustomTabsService.Stub {

public boolean warmup(long flags) {

// Here and in mayLaunchUrl(), don't do expensive work for background applications.

if (!isCallerForegroundOrSelf()) return false;

+ mClientManager.recordUidHasCalledWarmup(Binder.getCallingUid());

if (!mWarmupHasBeenCalled.compareAndSet(false, true)) return true;

// The call is non-blocking and this must execute on the UI thread, post a task.

ThreadUtils.postOnUiThread(new Runnable() {