Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1325203004: PPC: [es6] Introduce a dedicated JSIteratorResult type. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [es6] Introduce a dedicated JSIteratorResult type. Port 72bc4b5c8a5c4279bcb8b340edbc8aa1c46d75a1 Original commit message: Use a single JSIteratorResult type for all implementation provided iterator results (i.e. the String, Array and collection iterators, and also for generators). This removes one source of unnecessary polymorphism in for-of loops. It is accomplished by a new intrinsic %_CreateIterResultObject() that should be used to create iterator result objects from JavaScript builtins (there's a matching factory method for C++ code). Also restructure the %StringIteratorPrototype%.next() and %ArrayIteratorPrototype%.next() functions to be a bit more friendly to optimizing compilers. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Committed: https://crrev.com/fdbccd64f7054f8a3328311f036e4f59a1b52131 Cr-Commit-Position: refs/heads/master@{#30575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -26 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +41 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 3 months ago (2015-09-03 16:26:11 UTC) #1
dstence
lgtm
5 years, 3 months ago (2015-09-03 18:15:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325203004/1
5 years, 3 months ago (2015-09-03 18:17:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 18:41:27 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 18:41:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdbccd64f7054f8a3328311f036e4f59a1b52131
Cr-Commit-Position: refs/heads/master@{#30575}

Powered by Google App Engine
This is Rietveld 408576698