Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1325193007: Add use counters for global user prompt methods (Closed)

Created:
5 years, 3 months ago by alancutter (OOO until 2018)
Modified:
5 years, 3 months ago
Reviewers:
palmer, Timothy Loh
CC:
blink-reviews, Inactive, palmer, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add use counters for user prompt methods This change adds use counters for the following methods on window: - alert() - confirm() - prompt() - print() Committed: https://crrev.com/f1367b31dd09e4a9e7760bf9131c5bedeb9d7aa4 git-svn-id: svn://svn.chromium.org/blink/trunk@202018 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 2

Patch Set 3 : Dedup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M Source/core/frame/UseCounter.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
alancutter (OOO until 2018)
5 years, 3 months ago (2015-09-10 01:00:08 UTC) #2
Timothy Loh
On 2015/09/10 01:00:08, alancutter wrote: ok lgtm
5 years, 3 months ago (2015-09-10 01:00:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325193007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325193007/1
5 years, 3 months ago (2015-09-10 01:01:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/67407) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-10 01:02:32 UTC) #7
raymes
5 years, 3 months ago (2015-09-10 01:03:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325193007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325193007/20001
5 years, 3 months ago (2015-09-10 01:07:43 UTC) #13
palmer
https://codereview.chromium.org/1325193007/diff/20001/Source/core/frame/UseCounter.h File Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/1325193007/diff/20001/Source/core/frame/UseCounter.h#newcode846 Source/core/frame/UseCounter.h:846: V8Window_Alert_Method = 951, Why define this twice?
5 years, 3 months ago (2015-09-10 01:14:17 UTC) #15
alancutter (OOO until 2018)
https://codereview.chromium.org/1325193007/diff/20001/Source/core/frame/UseCounter.h File Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/1325193007/diff/20001/Source/core/frame/UseCounter.h#newcode846 Source/core/frame/UseCounter.h:846: V8Window_Alert_Method = 951, On 2015/09/10 at 01:14:17, palmer wrote: ...
5 years, 3 months ago (2015-09-10 01:19:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325193007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325193007/40001
5 years, 3 months ago (2015-09-10 01:19:34 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202018
5 years, 3 months ago (2015-09-10 02:39:48 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:06:30 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f1367b31dd09e4a9e7760bf9131c5bedeb9d7aa4

Powered by Google App Engine
This is Rietveld 408576698