Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1325193002: Fix didEvaluateWorkerScript expectation in WorkerThreadTest (Closed)

Created:
5 years, 3 months ago by kinuko
Modified:
5 years, 3 months ago
Reviewers:
falken
CC:
blink-reviews, kinuko+worker_chromium.org, horo+watch_chromium.org, falken, blink-worker-reviews_chromium.org, Takashi Toyoshima
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix didEvaluateWorkerScript expectation in WorkerThreadTest Longer term we should clean up initialize code as in crbug.com/519111. BUG=527636 TEST=WorkerThreadTest.StartAndStopImmediately Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/workers/WorkerThreadTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
kinuko
A short-term fix. PTL
5 years, 3 months ago (2015-09-03 06:44:18 UTC) #2
falken
lgtm
5 years, 3 months ago (2015-09-04 02:05:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325193002/1
5 years, 3 months ago (2015-09-04 02:15:13 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 02:19:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201760

Powered by Google App Engine
This is Rietveld 408576698