Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 1325183003: X87: [runtime] Remove useless IN builtin. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Remove useless IN builtin. port 3dc9b122fa9f7d551e05f5b9d7415bcfdcac92db (r30582). original commit message: Similar to DELETE, the IN builtin is just a thin wrapper for %HasElement and %HasProperty anyway, and cannot be optimized, plus it had a weird special fast case (which also involved at least one LOAD_IC plus some intrinsic magic). BUG= Committed: https://crrev.com/b2a47a0bc6c489a19bffa80796b2def9457ef715 Cr-Commit-Position: refs/heads/master@{#30613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-06 10:23:08 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-07 07:19:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325183003/1
5 years, 3 months ago (2015-09-07 07:19:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-07 08:26:02 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 08:26:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2a47a0bc6c489a19bffa80796b2def9457ef715
Cr-Commit-Position: refs/heads/master@{#30613}

Powered by Google App Engine
This is Rietveld 408576698