Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1325153004: GN: Change extension of debug pexe builds from .pexe-debug to .pexe.debug (Closed)

Created:
5 years, 3 months ago by Sergey Ulanov
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Change extension of debug pexe builds from .pexe-debug to .pexe.debug GYP build generate .pexe.debug. Also the pnacl toolchain in native_client/toolchain uses .pexe.debug extension. BUG=512899 Committed: https://crrev.com/f333696a0a014fae2a762cdac48776f3153d9284 Cr-Commit-Position: refs/heads/master@{#347172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/toolchain/nacl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Sergey Ulanov
5 years, 3 months ago (2015-09-03 00:54:18 UTC) #2
Sergey Ulanov
Just for context here is the file where we have dependency on pexe.debug name: remoting/webapp/crd/remoting_client_pnacl.nmf.jinja2 ...
5 years, 3 months ago (2015-09-03 00:58:56 UTC) #3
Dirk Pranke
lgtm. That was probably just a typo on my part, I think.
5 years, 3 months ago (2015-09-03 01:06:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325153004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325153004/1
5 years, 3 months ago (2015-09-03 16:49:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 17:20:59 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 17:21:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f333696a0a014fae2a762cdac48776f3153d9284
Cr-Commit-Position: refs/heads/master@{#347172}

Powered by Google App Engine
This is Rietveld 408576698