Issue 132513003: SampleApp Cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132513003: SampleApp Cleanup (Closed)

Created:
6 years, 11 months ago by hal.canary

Modified:
6 years, 11 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

SampleApp Cleanup: - Set resoursePath to sensible default. - Remove verbosity of DitherBitmap. - SampleEncode no longer tries to mkdir('/encoded'), now stores encoded data in memory and uses the SkDecodingImageGenerator to decode. BUG= R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=13015

Patch Set 1 #

Patch Set 2 : final rebase #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -37 lines)			Patch
M	samplecode/SampleApp.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samplecode/SampleDitherBitmap.cpp	View	4 chunks	+12 lines, -4 lines	0 comments	Download
M	samplecode/SampleEncode.cpp	View	4 chunks	+45 lines, -32 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hal.canary

6 years, 11 months ago (2014-01-10 14:53:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r13015 (presubmit successful).

Expand Messages | Collapse Messages