Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1540)

Unified Diff: chrome/common/content_settings_pattern_unittest.cc

Issue 13251012: Fix b180514: Some exception entries cannot be deleted from a setting panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/content_settings_pattern_unittest.cc
diff --git a/chrome/common/content_settings_pattern_unittest.cc b/chrome/common/content_settings_pattern_unittest.cc
index bd793382e87cc3a6c8019962622f52605084be16..8e465f44f66006a5eaa624f544ed8b8a31bfa955 100644
--- a/chrome/common/content_settings_pattern_unittest.cc
+++ b/chrome/common/content_settings_pattern_unittest.cc
@@ -194,18 +194,29 @@ TEST(ContentSettingsPatternTest, Wildcard) {
ContentSettingsPattern::Wildcard()));
}
-TEST(ContentSettingsPatternTest, TrimEndingDotFromHost) {
+TEST(ContentSettingsPatternTest, TrimEndingDots) {
EXPECT_TRUE(Pattern("www.example.com").IsValid());
EXPECT_TRUE(Pattern("www.example.com").Matches(
GURL("http://www.example.com")));
EXPECT_TRUE(Pattern("www.example.com").Matches(
- GURL("http://www.example.com.")));
+ GURL("http://www.example.com..")));
- EXPECT_TRUE(Pattern("www.example.com.").IsValid());
+ EXPECT_TRUE(Pattern("www.example.com..").IsValid());
EXPECT_STREQ("www.example.com",
- Pattern("www.example.com.").ToString().c_str());
+ Pattern("www.example.com..").ToString().c_str());
- EXPECT_TRUE(Pattern("www.example.com.") == Pattern("www.example.com"));
+ EXPECT_TRUE(Pattern("www.example.com..") == Pattern("www.example.com"));
+}
+
+TEST(ContentSettingsPatternTest, TrimEndingDotsWithStringConsistsOfDots) {
+ EXPECT_TRUE(Pattern(".").IsValid());
+ EXPECT_TRUE(Pattern(".").Matches(GURL("http://.")));
+ EXPECT_TRUE(Pattern(".").Matches(GURL("http://..")));
+
+ EXPECT_TRUE(Pattern("..").IsValid());
+ EXPECT_STREQ(".", Pattern("..").ToString().c_str());
+
+ EXPECT_TRUE(Pattern("..") == Pattern("."));
}
TEST(ContentSettingsPatternTest, FromString_WithNoWildcards) {
« chrome/common/content_settings_pattern.cc ('K') | « chrome/common/content_settings_pattern.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698