Fix b180514: Some exception entries cannot be deleted from a setting panel.

chrome/common/content_settings_pattern_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/content_settings_pattern.h"
 
 #include "googleurl/src/gurl.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
@@ skipping 188 matching lines @@
   EXPECT_TRUE(Pattern("www.example.com").Matches(
       GURL("http://www.example.com")));
   EXPECT_TRUE(Pattern("www.example.com").Matches(
       GURL("http://www.example.com.")));
 
   EXPECT_TRUE(Pattern("www.example.com.").IsValid());
   EXPECT_STREQ("www.example.com",
                Pattern("www.example.com.").ToString().c_str());
 
   EXPECT_TRUE(Pattern("www.example.com.") == Pattern("www.example.com"));
+
+  EXPECT_TRUE(Pattern(".").IsValid());

[markusheintz_, 2013/04/02 19:16:46]

An empty domain (host) does not make much sense for defining site specific
content settings exceptions since it does not match any particular domain.

Valid content settings patterns require the domain (host) to be non empty.

We should not allow this pattern.

[yhirano, 2013/04/02 19:54:54]

Done.

+  EXPECT_STREQ(".", Pattern(".").ToString().c_str());
 }
 
 TEST(ContentSettingsPatternTest, FromString_WithNoWildcards) {
   // HTTP patterns with default port.
   EXPECT_TRUE(Pattern("http://www.example.com:80").IsValid());
   EXPECT_STREQ("http://www.example.com:80",
                Pattern("http://www.example.com:80").ToString().c_str());
   // HTTP patterns with none default port.
   EXPECT_TRUE(Pattern("http://www.example.com:81").IsValid());
   EXPECT_STREQ("http://www.example.com:81",
@@ skipping 217 matching lines @@
 
   // Pattern strings with invalid port parts.
   EXPECT_FALSE(Pattern("example.com:abc").IsValid());
   EXPECT_STREQ("", Pattern("example.com:abc").ToString().c_str());
 
   // Invalid file pattern strings.
   EXPECT_FALSE(Pattern("file://").IsValid());
   EXPECT_STREQ("", Pattern("file://").ToString().c_str());
   EXPECT_FALSE(Pattern("file:///foo/bar.html:8080").IsValid());
   EXPECT_STREQ("", Pattern("file:///foo/bar.html:8080").ToString().c_str());
+
+  // Host have consequtive ending dots
+  EXPECT_FALSE(Pattern("www.example.com..").IsValid());
+  EXPECT_FALSE(Pattern("..").IsValid());
 }
 
 TEST(ContentSettingsPatternTest, UnequalOperator) {
   EXPECT_TRUE(Pattern("http://www.foo.com") != Pattern("http://www.foo.com*"));
   EXPECT_TRUE(Pattern("http://www.foo.com*") !=
               ContentSettingsPattern::Wildcard());
 
   EXPECT_TRUE(Pattern("http://www.foo.com") !=
               ContentSettingsPattern::Wildcard());
 
@@ skipping 201 matching lines @@
   // file:/// normalization.
   EXPECT_STREQ("file:///tmp/test.html",
                Pattern("file:///tmp/bar/../test.html").ToString().c_str());
 
   // Invalid patterns.
   EXPECT_STREQ("", Pattern("*example.com").ToString().c_str());
   EXPECT_STREQ("", Pattern("example.*").ToString().c_str());
   EXPECT_STREQ("", Pattern("*\xC4\x87ira.com").ToString().c_str());
   EXPECT_STREQ("", Pattern("\xC4\x87ira.*").ToString().c_str());
 }