Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1325053009: cygprofile: increase timeouts to allow showing web contents (Closed)

Created:
5 years, 3 months ago by pasko
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cygprofile: increase timeouts to allow showing web contents Also doing a fork() changes thread id (syscall gettid), which breaks the assumptions in cygprofile.cc, disabled a fork in library_prefetcher. Verified: with these changes the instrumented build is able to display the contents of 'https://google.com'. It does not finish loading though, which is probably due to some other timeouts. BUG=503613 Committed: https://crrev.com/e3a753f17bac62738b0dbf0b36510f767b081e4b Cr-Commit-Position: refs/heads/master@{#347918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M base/android/library_loader/library_prefetcher.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M build/common.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
pasko
rmcilroy@chromium.org: Please review changes in: base/android/library_loader/library_prefetcher.cc jbudorick@chromium.org: Please review changes in: build/common.gypi sievers@chromium.org: Please review ...
5 years, 3 months ago (2015-09-08 17:06:13 UTC) #2
jbudorick
build/ lgtm
5 years, 3 months ago (2015-09-08 17:09:51 UTC) #3
no sievers
content lgtm
5 years, 3 months ago (2015-09-08 18:47:44 UTC) #4
rmcilroy
On 2015/09/08 18:47:44, sievers wrote: > content lgtm base/ lgtm
5 years, 3 months ago (2015-09-09 11:38:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325053009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325053009/1
5 years, 3 months ago (2015-09-09 11:48:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 12:56:47 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 12:57:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3a753f17bac62738b0dbf0b36510f767b081e4b
Cr-Commit-Position: refs/heads/master@{#347918}

Powered by Google App Engine
This is Rietveld 408576698