- Remove scanning by regular expression and redundant scanning.

- Remove scanning by regular expression and redundant scanning.

[Ivan Posva, 2015-09-02 06:26:30]

iposva@google.com changed reviewers:
+ rnystrom@google.com

[Bob Nystrom, 2015-09-02 16:28:01]

rnystrom@google.com changed reviewers:
+ nweiz@google.com

[Bob Nystrom, 2015-09-02 16:28:02]

Thank you for doing this!

I'll hand this off to Natalie since YAML is mostly her baby. This is going to
need a bunch of style changes, do you want to do those, or should we just take
it from here?

[nweiz, 2015-09-02 18:56:23]

On 2015/09/02 16:28:02, Bob Nystrom wrote:
> Thank you for doing this!
> 
> I'll hand this off to Natalie since YAML is mostly her baby. This is going to
> need a bunch of style changes, do you want to do those, or should we just take
> it from here?

It looks like a bunch of the tests don't pass with this.

[Ivan Posva, 2015-09-02 19:19:04]

On 2015/09/02 18:56:23, nweiz wrote:
> On 2015/09/02 16:28:02, Bob Nystrom wrote:
> > Thank you for doing this!
> > 
> > I'll hand this off to Natalie since YAML is mostly her baby. This is going
to
> > need a bunch of style changes, do you want to do those, or should we just
take
> > it from here?
> 
> It looks like a bunch of the tests don't pass with this.

Care to be a tiny bit more specific? I ran all the tests I could find in the
yaml repo, which are yaml_test.dart and yaml_node_wrapper_test.dart, and they
are green all the way.

Thanks,
-Ivan

[nweiz, 2015-09-02 20:22:41]

On 2015/09/02 19:19:04, Ivan Posva wrote:
> On 2015/09/02 18:56:23, nweiz wrote:
> > On 2015/09/02 16:28:02, Bob Nystrom wrote:
> > > Thank you for doing this!
> > > 
> > > I'll hand this off to Natalie since YAML is mostly her baby. This is going
> to
> > > need a bunch of style changes, do you want to do those, or should we just
> take
> > > it from here?
> > 
> > It looks like a bunch of the tests don't pass with this.
> 
> Care to be a tiny bit more specific? I ran all the tests I could find in the
> yaml repo, which are yaml_test.dart and yaml_node_wrapper_test.dart, and they
> are green all the way.
> 
> Thanks,
> -Ivan

When I patch this in to a080e6b8b0b2609858a755797386079c20c2aa02 (the last
revision it merges cleanly with), run "pub upgrade", and run "pub run test" I
get this output: https://gist.github.com/nex3/e35aedbb2900512a6a8d

[Ivan Posva, 2015-09-02 20:59:13]

On 2015/09/02 20:22:41, nweiz wrote:
> On 2015/09/02 19:19:04, Ivan Posva wrote:
> > On 2015/09/02 18:56:23, nweiz wrote:
> > > On 2015/09/02 16:28:02, Bob Nystrom wrote:
> > > > Thank you for doing this!
> > > > 
> > > > I'll hand this off to Natalie since YAML is mostly her baby. This is
going
> > to
> > > > need a bunch of style changes, do you want to do those, or should we
just
> > take
> > > > it from here?
> > > 
> > > It looks like a bunch of the tests don't pass with this.
> > 
> > Care to be a tiny bit more specific? I ran all the tests I could find in the
> > yaml repo, which are yaml_test.dart and yaml_node_wrapper_test.dart, and
they
> > are green all the way.
> > 
> > Thanks,
> > -Ivan
> 
> When I patch this in to a080e6b8b0b2609858a755797386079c20c2aa02 (the last
> revision it merges cleanly with), run "pub upgrade", and run "pub run test" I
> get this output: https://gist.github.com/nex3/e35aedbb2900512a6a8d

Thanks! Should have also tested checked mode...

"pub run test" now works cleanly.

-Ivan

[nweiz, 2015-09-02 21:17:25]

On 2015/09/02 20:59:13, Ivan Posva wrote:
> On 2015/09/02 20:22:41, nweiz wrote:
> > On 2015/09/02 19:19:04, Ivan Posva wrote:
> > > On 2015/09/02 18:56:23, nweiz wrote:
> > > > On 2015/09/02 16:28:02, Bob Nystrom wrote:
> > > > > Thank you for doing this!
> > > > > 
> > > > > I'll hand this off to Natalie since YAML is mostly her baby. This is
> going
> > > to
> > > > > need a bunch of style changes, do you want to do those, or should we
> just
> > > take
> > > > > it from here?
> > > > 
> > > > It looks like a bunch of the tests don't pass with this.
> > > 
> > > Care to be a tiny bit more specific? I ran all the tests I could find in
the
> > > yaml repo, which are yaml_test.dart and yaml_node_wrapper_test.dart, and
> they
> > > are green all the way.
> > > 
> > > Thanks,
> > > -Ivan
> > 
> > When I patch this in to a080e6b8b0b2609858a755797386079c20c2aa02 (the last
> > revision it merges cleanly with), run "pub upgrade", and run "pub run test"
I
> > get this output: https://gist.github.com/nex3/e35aedbb2900512a6a8d
> 
> Thanks! Should have also tested checked mode...
> 
> "pub run test" now works cleanly.
> 
> -Ivan

Awesome, thanks! I'll take it over from here.

[Ivan Posva, 2015-09-02 21:32:23]

On 2015/09/02 21:17:25, nweiz wrote:
> On 2015/09/02 20:59:13, Ivan Posva wrote:
> > On 2015/09/02 20:22:41, nweiz wrote:
> > > On 2015/09/02 19:19:04, Ivan Posva wrote:
> > > > On 2015/09/02 18:56:23, nweiz wrote:
> > > > > On 2015/09/02 16:28:02, Bob Nystrom wrote:
> > > > > > Thank you for doing this!
> > > > > > 
> > > > > > I'll hand this off to Natalie since YAML is mostly her baby. This is
> > going
> > > > to
> > > > > > need a bunch of style changes, do you want to do those, or should we
> > just
> > > > take
> > > > > > it from here?
> > > > > 
> > > > > It looks like a bunch of the tests don't pass with this.
> > > > 
> > > > Care to be a tiny bit more specific? I ran all the tests I could find in
> the
> > > > yaml repo, which are yaml_test.dart and yaml_node_wrapper_test.dart, and
> > they
> > > > are green all the way.
> > > > 
> > > > Thanks,
> > > > -Ivan
> > > 
> > > When I patch this in to a080e6b8b0b2609858a755797386079c20c2aa02 (the last
> > > revision it merges cleanly with), run "pub upgrade", and run "pub run
test"
> I
> > > get this output: https://gist.github.com/nex3/e35aedbb2900512a6a8d
> > 
> > Thanks! Should have also tested checked mode...
> > 
> > "pub run test" now works cleanly.
> > 
> > -Ivan
> 
> Awesome, thanks! I'll take it over from here.

Updated to ToT now.

-Ivan