Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 132503005: When dumping the stack, try to print contents as ASCII (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

When dumping the stack, try to print contents as ASCII This makes it easier to find strings that are on the stack for debugging BUG=none LOG=n R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23045

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M tools/grokdump.py View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
wdyt is that useful in general?
6 years, 4 months ago (2014-08-11 14:01:47 UTC) #1
Jakob Kummerow
lgtm
6 years, 4 months ago (2014-08-11 14:12:37 UTC) #2
jochen (gone - plz use gerrit)
6 years, 4 months ago (2014-08-11 14:16:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 23045 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698