Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: content/browser/media/webrtc_browsertest.cc

Issue 132503002: video: On ChromeOS don't assume GLX always. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: videodecode: movedcheck Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/webrtc_browsertest.cc
diff --git a/content/browser/media/webrtc_browsertest.cc b/content/browser/media/webrtc_browsertest.cc
index a2f9cf9bce35087cf6059633226247df693e135e..e9b2206bbb947a4138efb7f106b02bae26be5133 100644
--- a/content/browser/media/webrtc_browsertest.cc
+++ b/content/browser/media/webrtc_browsertest.cc
@@ -88,6 +88,12 @@ class WebrtcBrowserTest: public ContentBrowserTest {
WebrtcBrowserTest() {}
virtual ~WebrtcBrowserTest() {}
+ virtual void SetUp() OVERRIDE {
+ // These tests require pixel output.
+ UseRealGLContexts();
danakj 2014/01/10 17:55:42 I removed this from this CL as it's not needed (ye
+ ContentBrowserTest::SetUp();
+ }
+
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
// We need fake devices in this test since we want to run on naked VMs. We
// assume these switches are set by default in content_browsertests.
@@ -95,10 +101,6 @@ class WebrtcBrowserTest: public ContentBrowserTest {
switches::kUseFakeDeviceForMediaStream));
ASSERT_TRUE(CommandLine::ForCurrentProcess()->HasSwitch(
switches::kUseFakeUIForMediaStream));
-
- // The video playback will not work without a GPU, so force its use here.
- // This may not be available on all VMs though.
- command_line->AppendSwitch(switches::kUseGpuInTests);
}
void DumpChromeTraceCallback(
« no previous file with comments | « content/browser/media/webrtc_aecdump_browsertest.cc ('k') | content/common/gpu/media/gpu_video_decode_accelerator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698