Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1325023003: [es6] Fix invalid ToObject in String/Array iterator next. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fix invalid ToObject in String/Array iterator next. The spec says that the "this value" has to be an Object. R=jarin@chromium.org Committed: https://crrev.com/9427d3255b2eba784a6a61ea998b566ff7d07c4b Cr-Commit-Position: refs/heads/master@{#30533}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/array-iterator.js View 1 chunk +3 lines, -2 lines 2 comments Download
M src/string-iterator.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 3 months ago (2015-09-02 06:36:23 UTC) #1
Benedikt Meurer
Hey Jaro, This is the fix we talked about. Pretty straight forward. Please take a ...
5 years, 3 months ago (2015-09-02 06:36:51 UTC) #2
Jarin
lgtm with a nit. https://codereview.chromium.org/1325023003/diff/1/src/array-iterator.js File src/array-iterator.js (right): https://codereview.chromium.org/1325023003/diff/1/src/array-iterator.js#newcode82 src/array-iterator.js:82: !HAS_DEFINED_PRIVATE(iterator, arrayIteratorNextIndexSymbol)) { Technically, you ...
5 years, 3 months ago (2015-09-02 06:41:02 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1325023003/diff/1/src/array-iterator.js File src/array-iterator.js (right): https://codereview.chromium.org/1325023003/diff/1/src/array-iterator.js#newcode82 src/array-iterator.js:82: !HAS_DEFINED_PRIVATE(iterator, arrayIteratorNextIndexSymbol)) { Yeah, I'll remove all of this ...
5 years, 3 months ago (2015-09-02 06:42:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1325023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1325023003/1
5 years, 3 months ago (2015-09-02 06:42:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 06:59:03 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 06:59:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9427d3255b2eba784a6a61ea998b566ff7d07c4b
Cr-Commit-Position: refs/heads/master@{#30533}

Powered by Google App Engine
This is Rietveld 408576698