Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issue 1324943003: Move the android logging doc to //docs (Closed)

Created:
5 years, 3 months ago by dgn
Modified:
5 years, 3 months ago
Reviewers:
Bernhard Bauer, Yaron
CC:
chromium-reviews, nodir, Bons
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the android logging doc to //docs BUG= Committed: https://crrev.com/97b9a25cc39c67941f86403d03937913ffd4b95f Cr-Commit-Position: refs/heads/master@{#346937}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated ref to the doc in the java class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -278 lines) Patch
M base/android/java/src/org/chromium/base/Log.java View 1 1 chunk +1 line, -1 line 0 comments Download
D base/android/java/src/org/chromium/base/README_logging.md View 1 chunk +0 lines, -162 lines 0 comments Download
A + docs/android_logging.md View 1 2 chunks +156 lines, -115 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
dgn
PTAL. You can have a preview of the new file here: http://go/review-logging-md
5 years, 3 months ago (2015-09-02 09:35:37 UTC) #2
Bernhard Bauer
lgtm https://codereview.chromium.org/1324943003/diff/1/docs/android_logging.md File docs/android_logging.md (right): https://codereview.chromium.org/1324943003/diff/1/docs/android_logging.md#newcode1 docs/android_logging.md:1: # Logging # I wonder why this doesn't ...
5 years, 3 months ago (2015-09-02 10:40:15 UTC) #3
dgn
https://codereview.chromium.org/1324943003/diff/1/docs/android_logging.md File docs/android_logging.md (right): https://codereview.chromium.org/1324943003/diff/1/docs/android_logging.md#newcode1 docs/android_logging.md:1: # Logging # On 2015/09/02 10:40:15, Bernhard Bauer wrote: ...
5 years, 3 months ago (2015-09-02 10:57:50 UTC) #4
dgn
https://codereview.chromium.org/1324943003/diff/1/docs/android_logging.md File docs/android_logging.md (right): https://codereview.chromium.org/1324943003/diff/1/docs/android_logging.md#newcode1 docs/android_logging.md:1: # Logging # On 2015/09/02 10:57:50, dgn wrote: > ...
5 years, 3 months ago (2015-09-02 11:03:10 UTC) #5
Bernhard Bauer
On 2015/09/02 11:03:10, dgn wrote: > https://codereview.chromium.org/1324943003/diff/1/docs/android_logging.md > File docs/android_logging.md (right): > > https://codereview.chromium.org/1324943003/diff/1/docs/android_logging.md#newcode1 > ...
5 years, 3 months ago (2015-09-02 11:11:33 UTC) #6
Yaron
lgtm
5 years, 3 months ago (2015-09-02 13:27:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324943003/20001
5 years, 3 months ago (2015-09-02 13:31:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-02 16:36:54 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 16:38:06 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/97b9a25cc39c67941f86403d03937913ffd4b95f
Cr-Commit-Position: refs/heads/master@{#346937}

Powered by Google App Engine
This is Rietveld 408576698