Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1324853005: Reland of Fix typo in install-sysroot.py (Closed)

Created:
5 years, 3 months ago by Adrian Kuegel
Modified:
5 years, 3 months ago
CC:
chromium-reviews, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@cleanup_sysroot_settings
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Fix typo in install-sysroot.py (patchset #1 id:1 of https://codereview.chromium.org/1315773003/ ) Reason for revert: The check_licenses script has been fixed, and it cycled green: https://build.chromium.org/p/chromium/builders/Linux/builds/66708 Original issue's description: > Revert of Fix typo in install-sysroot.py (patchset #2 id:20001 of https://codereview.chromium.org/1317973005/ ) > > Reason for revert: > Caused check_licenses to fail: > > https://build.chromium.org/p/chromium/builders/Linux/builds/66701 > > Original issue's description: > > Fix typo in install-sysroot.py > > > > install-sysroot.py was intended to default to installing > > the sysroot ia32, but within this script 'i386' is used to > > refer to this architecture. > > > > This most likely went unnoticed since the ia32 builder > > either use branding=Official, or explicitly set > > use_sysroot=1, or have a complete set of packages for > > cross building on the host system. > > > > BUG=504446 > > > > Committed: https://crrev.com/1d62049b4c176fbd43bed90fc9a76273b11ad406 > > Cr-Commit-Position: refs/heads/master@{#347821} > > TBR=dpranke@chromium.org,sbc@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=504446 > > Committed: https://crrev.com/3b27a2de111759359162bcad49753e17ee1cf002 > Cr-Commit-Position: refs/heads/master@{#347839} TBR=dpranke@chromium.org,sbc@chromium.org,chrishtr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504446 Committed: https://crrev.com/064aca24669857d48458749952a3bc7c9c516e63 Cr-Commit-Position: refs/heads/master@{#347901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/linux/sysroot_scripts/install-sysroot.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Adrian Kuegel
Created Reland of Fix typo in install-sysroot.py
5 years, 3 months ago (2015-09-09 10:27:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324853005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324853005/1
5 years, 3 months ago (2015-09-09 10:27:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-09 10:28:19 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/064aca24669857d48458749952a3bc7c9c516e63 Cr-Commit-Position: refs/heads/master@{#347901}
5 years, 3 months ago (2015-09-09 10:29:24 UTC) #4
Sam Clegg
5 years, 3 months ago (2015-09-09 12:55:26 UTC) #5
Message was sent while issue was closed.
On 2015/09/09 10:29:24, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/064aca24669857d48458749952a3bc7c9c516e63
> Cr-Commit-Position: refs/heads/master@{#347901}

Thanks!  lgtm

Powered by Google App Engine
This is Rietveld 408576698