Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1324763005: Revert of [turbofan] Greedy: using hints (Closed)

Created:
5 years, 3 months ago by Michael Hablich
Modified:
5 years, 3 months ago
CC:
v8-dev, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Greedy: using hints (patchset #2 id:60001 of https://codereview.chromium.org/1329493004/ ) Reason for revert: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20greedy%20allocator/builds/1338 Original issue's description: > [turbofan] Greedy: using hints > > This is a rudimentary introduction of hints. Primarily this helps with > allocating on the same register variables are defined (from instructions) > For dealing with phis, we need to introduce groups, in a subsequent > CL. > > From the last CL (memory ops heuristics), this CL improves some > benchmarks - notably Life (11.94%) in Emscripten x64, and Memops > (Emscripten), 24% on x86; notable regressions: Memops in > AreWeFastYet (-14%, x64) and Corrections -25% on x86. > > BUG= > > Committed: https://crrev.com/038f5eaf3bd6796ed6b7519de83c21d4e1f54850 > Cr-Commit-Position: refs/heads/master@{#30534} TBR=jarin@chromium.org,bmeurer@chromium.org,mtrofin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/93f1f198a629420d416d9e4805b921a807b5b7d6 Cr-Commit-Position: refs/heads/master@{#30537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -36 lines) Patch
M src/compiler/greedy-allocator.cc View 4 chunks +27 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Hablich
Created Revert of [turbofan] Greedy: using hints
5 years, 3 months ago (2015-09-02 08:34:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324763005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324763005/1
5 years, 3 months ago (2015-09-02 08:34:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 08:35:10 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 08:35:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93f1f198a629420d416d9e4805b921a807b5b7d6
Cr-Commit-Position: refs/heads/master@{#30537}

Powered by Google App Engine
This is Rietveld 408576698