Add AsyncMemoizer.future.

Add AsyncMemoizer.future.

R=lrn@google.com

Committed: https://github.com/dart-lang/async/commit/7b94635668aa790a96695f4260495e33749de2a4

[Lasse Reichstein Nielsen, 2015-09-03 05:03:55]

lgtm

[kevmoo, 2015-09-03 11:58:33]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2015-09-03 11:58:33]

DBC: lean on reified types a bit to help folks in checked mode?

https://codereview.chromium.org/1324743003/diff/20001/lib/src/async_memoizer....
File lib/src/async_memoizer.dart (right):

https://codereview.chromium.org/1324743003/diff/20001/lib/src/async_memoizer....
lib/src/async_memoizer.dart:36: final _completer = new Completer();
Completer<T>

https://codereview.chromium.org/1324743003/diff/20001/lib/src/async_memoizer....
lib/src/async_memoizer.dart:45: if (!hasRun) _completer.complete(new
Future.sync(computation));
new Future<T> ?

[nweiz, 2015-09-08 21:07:24]

On 2015/09/03 11:58:33, kevmoo wrote:
> DBC: lean on reified types a bit to help folks in checked mode?
> 
>
https://codereview.chromium.org/1324743003/diff/20001/lib/src/async_memoizer....
> File lib/src/async_memoizer.dart (right):
> 
>
https://codereview.chromium.org/1324743003/diff/20001/lib/src/async_memoizer....
> lib/src/async_memoizer.dart:36: final _completer = new Completer();
> Completer<T>
> 
>
https://codereview.chromium.org/1324743003/diff/20001/lib/src/async_memoizer....
> lib/src/async_memoizer.dart:45: if (!hasRun) _completer.complete(new
> Future.sync(computation));
> new Future<T> ?

Reified types for futures in particular vanish almost immediately once anyone
touches anything, and don't really provide useful checking anyway.

[nweiz, 2015-09-08 21:08:16]

Committed patchset #2 (id:20001) manually as
7b94635668aa790a96695f4260495e33749de2a4 (presubmit successful).

[kevmoo, 2015-09-08 22:29:18]

On 2015/09/08 21:07:24, nweiz wrote:
> On 2015/09/03 11:58:33, kevmoo wrote:
> > DBC: lean on reified types a bit to help folks in checked mode?
> > 
> >
>
https://codereview.chromium.org/1324743003/diff/20001/lib/src/async_memoizer....
> > File lib/src/async_memoizer.dart (right):
> > 
> >
>
https://codereview.chromium.org/1324743003/diff/20001/lib/src/async_memoizer....
> > lib/src/async_memoizer.dart:36: final _completer = new Completer();
> > Completer<T>
> > 
> >
>
https://codereview.chromium.org/1324743003/diff/20001/lib/src/async_memoizer....
> > lib/src/async_memoizer.dart:45: if (!hasRun) _completer.complete(new
> > Future.sync(computation));
> > new Future<T> ?
> 
> Reified types for futures in particular vanish almost immediately once anyone
> touches anything, and don't really provide useful checking anyway.

Er, well, if computation returned something incompatible, you get a runtime
exception in checked mode – that's enough to be useful IMHO