Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 132473009: Allow tests to stub out GL draw calls. (Closed)

Created:
6 years, 11 months ago by danakj
Modified:
6 years, 11 months ago
Reviewers:
no sievers, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Allow tests to stub out GL draw calls. This allows us to use real GL bindings but without drawing when we don't care about pixel output, allowing for faster execution. In particular this will allow us to use OSMesa instead of a completely fake GL implementation in the compositor for browser tests. We add a new kDisableGLDrawingForTests command line flag that can be set to prevent the GL draw calls from doing any work. We will be able to set this flag in the browser test environment for any tests that don't require real pixel output. R=piman, sievers BUG=270918 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244405

Patch Set 1 #

Patch Set 2 : stubglbindings: nulldraw #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -9 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/generate_bindings.py View 1 10 chunks +53 lines, -9 lines 0 comments Download
M ui/gl/gl_bindings.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_implementation.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M ui/gl/gl_surface.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danakj
Here's a CL with just the stub draw calls in it. I'll make use of ...
6 years, 11 months ago (2014-01-10 22:58:41 UTC) #1
danakj
Patch set 2 renames to NullDraw
6 years, 11 months ago (2014-01-10 23:09:34 UTC) #2
piman
lgtm
6 years, 11 months ago (2014-01-11 00:54:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/132473009/40001
6 years, 11 months ago (2014-01-11 19:25:06 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-12 02:09:48 UTC) #5
Message was sent while issue was closed.
Change committed as 244405

Powered by Google App Engine
This is Rietveld 408576698