Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <lint> | 2 <lint> |
| 3 <!-- | 3 <!-- |
| 4 STOP! It looks like you want to suppress some lint errors: | 4 STOP! It looks like you want to suppress some lint errors: |
| 5 - Have you tried identifing the offending patch? | 5 - Have you tried identifing the offending patch? |
| 6 Ask the author for a fix and/or revert the patch. | 6 Ask the author for a fix and/or revert the patch. |
| 7 - It is preferred to add suppressions in the code instead of | 7 - It is preferred to add suppressions in the code instead of |
| 8 sweeping it under the rug here. See: | 8 sweeping it under the rug here. See: |
| 9 | 9 |
| 10 http://developer.android.com/tools/debugging/improving-w-lint.html | 10 http://developer.android.com/tools/debugging/improving-w-lint.html |
| (...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 68 <issue id="MissingRegistered" severity="ignore"/> | 68 <issue id="MissingRegistered" severity="ignore"/> |
| 69 <issue id="MissingSuperCall"> | 69 <issue id="MissingSuperCall"> |
| 70 <ignore path="android_webview/java/src/org/chromium/android_webview/AwConten ts.java"/> | 70 <ignore path="android_webview/java/src/org/chromium/android_webview/AwConten ts.java"/> |
| 71 <ignore path="content/public/android/java/src/org/chromium/content/browser/C ontentViewCore.java"/> | 71 <ignore path="content/public/android/java/src/org/chromium/content/browser/C ontentViewCore.java"/> |
| 72 </issue> | 72 </issue> |
| 73 <issue id="MissingVersion"> | 73 <issue id="MissingVersion"> |
| 74 <ignore path="AndroidManifest.xml"/> | 74 <ignore path="AndroidManifest.xml"/> |
| 75 </issue> | 75 </issue> |
| 76 <issue id="NewApi"> | 76 <issue id="NewApi"> |
| 77 <ignore path="PRODUCT_DIR/chromium_testshell_test_apk/classes/org/chromium/p rinting/PrintingControllerTest$6.class"/> | 77 <ignore path="PRODUCT_DIR/chromium_testshell_test_apk/classes/org/chromium/p rinting/PrintingControllerTest$6.class"/> |
| 78 <ignore path="PRODUCT_DIR/chromium_testshell_test_apk/classes/org/chromium/p rinting/PrintingControllerTest$7.class"/> | |
|
boliu
2014/01/10 00:11:45
I removed a .class file for android_webview. Do yo
frankf
2014/01/10 01:38:04
Lint rules can use both java and class files. Not
| |
| 78 <ignore path="PRODUCT_DIR/chromium_testshell_test_apk/classes/org/chromium/p rinting/PrintingControllerTest.class"/> | 79 <ignore path="PRODUCT_DIR/chromium_testshell_test_apk/classes/org/chromium/p rinting/PrintingControllerTest.class"/> |
| 79 <ignore path="PRODUCT_DIR/content_shell_test_apk/classes/org/chromium/conten t/browser/ClipboardTest.class"/> | 80 <ignore path="PRODUCT_DIR/content_shell_test_apk/classes/org/chromium/conten t/browser/ClipboardTest.class"/> |
| 80 <ignore path="android_webview/java/src/org/chromium/android_webview/AwPdfExp orter.java"/> | 81 <ignore path="android_webview/java/src/org/chromium/android_webview/AwPdfExp orter.java"/> |
| 81 <ignore path="android_webview/java/src/org/chromium/android_webview/AwPrintD ocumentAdapter.java"/> | 82 <ignore path="android_webview/java/src/org/chromium/android_webview/AwPrintD ocumentAdapter.java"/> |
| 82 <ignore path="android_webview/java/src/org/chromium/android_webview/AwWebCon tentsDelegateAdapter.java"/> | 83 <ignore path="android_webview/java/src/org/chromium/android_webview/AwWebCon tentsDelegateAdapter.java"/> |
| 83 <ignore path="android_webview/test/shell/src/org/chromium/android_webview/te st/AwTestContainerView.java"/> | 84 <ignore path="android_webview/test/shell/src/org/chromium/android_webview/te st/AwTestContainerView.java"/> |
| 84 <ignore path="base/android/java/src/org/chromium/base/ApiCompatibilityUtils. java"/> | 85 <ignore path="base/android/java/src/org/chromium/base/ApiCompatibilityUtils. java"/> |
| 85 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/BookmarkUt ils.java"/> | 86 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/BookmarkUt ils.java"/> |
| 86 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/TtsPlatfor mImpl.java"/> | 87 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/TtsPlatfor mImpl.java"/> |
| 87 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/appmenu/Ap pMenu.java"/> | 88 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/appmenu/Ap pMenu.java"/> |
| (...skipping 14 matching lines...) Expand all Loading... | |
| 102 <ignore path="media/base/android/java/src/org/chromium/media/MediaDrmBridge. java"/> | 103 <ignore path="media/base/android/java/src/org/chromium/media/MediaDrmBridge. java"/> |
| 103 <ignore path="media/base/android/java/src/org/chromium/media/VideoCapture.ja va"/> | 104 <ignore path="media/base/android/java/src/org/chromium/media/VideoCapture.ja va"/> |
| 104 <ignore path="media/base/android/java/src/org/chromium/media/WebAudioMediaCo decBridge.java"/> | 105 <ignore path="media/base/android/java/src/org/chromium/media/WebAudioMediaCo decBridge.java"/> |
| 105 <ignore path="printing/android/java/src/org/chromium/printing/PrintDocumentA dapterWrapper.java"/> | 106 <ignore path="printing/android/java/src/org/chromium/printing/PrintDocumentA dapterWrapper.java"/> |
| 106 <ignore path="printing/android/java/src/org/chromium/printing/PrintManagerDe legateImpl.java"/> | 107 <ignore path="printing/android/java/src/org/chromium/printing/PrintManagerDe legateImpl.java"/> |
| 107 <ignore path="printing/android/java/src/org/chromium/printing/PrintingContro llerImpl.java"/> | 108 <ignore path="printing/android/java/src/org/chromium/printing/PrintingContro llerImpl.java"/> |
| 108 <ignore path="tools/android/memconsumer/java/src/org/chromium/memconsumer/Re sidentService.java"/> | 109 <ignore path="tools/android/memconsumer/java/src/org/chromium/memconsumer/Re sidentService.java"/> |
| 109 <ignore path="ui/android/java/src/org/chromium/ui/ColorPickerAdvancedCompone nt.java"/> | 110 <ignore path="ui/android/java/src/org/chromium/ui/ColorPickerAdvancedCompone nt.java"/> |
| 110 <ignore path="ui/android/java/src/org/chromium/ui/base/Clipboard.java"/> | 111 <ignore path="ui/android/java/src/org/chromium/ui/base/Clipboard.java"/> |
| 111 <ignore path="ui/android/java/src/org/chromium/ui/base/LocalizationUtils.jav a"/> | 112 <ignore path="ui/android/java/src/org/chromium/ui/base/LocalizationUtils.jav a"/> |
| 113 <ignore path="ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java "/> | |
| 112 <ignore path="ui/android/java/src/org/chromium/ui/gl/SurfaceTexturePlatformW rapper.java"/> | 114 <ignore path="ui/android/java/src/org/chromium/ui/gl/SurfaceTexturePlatformW rapper.java"/> |
| 113 </issue> | 115 </issue> |
| 114 <issue id="OldTargetApi"> | 116 <issue id="OldTargetApi"> |
| 115 <ignore path="AndroidManifest.xml"/> | 117 <ignore path="AndroidManifest.xml"/> |
| 116 </issue> | 118 </issue> |
| 117 <issue id="Recycle" severity="Error"> | 119 <issue id="Recycle" severity="ignore"/> |
|
boliu
2014/01/10 00:11:45
Yay
| |
| 118 <ignore path="PRODUCT_DIR/content_shell_test_apk/classes/org/chromium/conten t/browser/ContentViewGestureHandlerTest.class"/> | |
| 119 <ignore path="android_webview/javatests/src/org/chromium/android_webview/tes t/WebKitHitTestTest.java"/> | |
| 120 <ignore path="android_webview/javatests/src/org/chromium/android_webview/tes t/util/AwTestTouchUtils.java"/> | |
| 121 <ignore path="chrome/android/javatests/src/org/chromium/chrome/browser/test/ ProviderBookmarkNodeTest.java"/> | |
| 122 <ignore path="content/public/test/android/javatests/src/org/chromium/content /browser/test/util/TestTouchUtils.java"/> | |
| 123 <ignore path="content/public/test/android/javatests/src/org/chromium/content /browser/test/util/TouchCommon.java"/> | |
| 124 </issue> | |
| 125 <issue id="Registered" severity="ignore"/> | 120 <issue id="Registered" severity="ignore"/> |
| 126 <issue id="SdCardPath"> | 121 <issue id="SdCardPath"> |
| 127 <ignore path="content/public/android/java/src/org/chromium/content/browser/M ediaResourceGetter.java"/> | 122 <ignore path="content/public/android/java/src/org/chromium/content/browser/M ediaResourceGetter.java"/> |
| 128 </issue> | 123 </issue> |
| 129 <issue id="SetJavaScriptEnabled" severity="ignore"/> | 124 <issue id="SetJavaScriptEnabled" severity="ignore"/> |
| 130 <issue id="UseSparseArrays"> | 125 <issue id="UseSparseArrays"> |
| 131 <ignore path="android_webview/java/src/org/chromium/android_webview/AwResour ce.java"/> | 126 <ignore path="android_webview/java/src/org/chromium/android_webview/AwResour ce.java"/> |
| 132 <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDe tector.java"/> | 127 <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDe tector.java"/> |
| 133 <ignore path="ui/android/java/src/org/chromium/ui/base/WindowAndroid.java"/> | 128 <ignore path="ui/android/java/src/org/chromium/ui/base/WindowAndroid.java"/> |
| 134 </issue> | 129 </issue> |
| 135 <issue id="ViewConstructor" severity="ignore"/> | 130 <issue id="ViewConstructor" severity="ignore"/> |
| 136 <issue id="WrongCall" severity="ignore"/> | 131 <issue id="WrongCall" severity="ignore"/> |
| 137 </lint> | 132 </lint> |
| OLD | NEW |