Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <lint> | 2 <lint> |
| 3 <!-- | 3 <!-- |
| 4 STOP! It looks like you want to suppress some lint errors: | 4 STOP! It looks like you want to suppress some lint errors: |
| 5 - Have you tried identifing the offending patch? | 5 - Have you tried identifing the offending patch? |
| 6 Ask the author for a fix and/or revert the patch. | 6 Ask the author for a fix and/or revert the patch. |
| 7 - It is preferred to add suppressions in the code instead of | 7 - It is preferred to add suppressions in the code instead of |
| 8 sweeping it under the rug here. See: | 8 sweeping it under the rug here. See: |
| 9 | 9 |
| 10 http://developer.android.com/tools/debugging/improving-w-lint.html | 10 http://developer.android.com/tools/debugging/improving-w-lint.html |
| 11 | 11 |
| 12 Still reading? | 12 Still reading? |
| 13 - You can edit this file manually to suppress an issue | 13 - You can edit this file manually to suppress an issue |
| 14 globally if it is not applicable to the project. | 14 globally if it is not applicable to the project. |
| 15 - You can also automatically add issues found so for in the | 15 - You can also automatically add issues found so for in the |
| 16 build process by running: | 16 build process by running: |
| 17 | 17 |
| 18 build/android/lint/suppress.py | 18 build/android/lint/suppress.py |
| 19 | 19 |
| 20 which will generate this file (Comments are not preserved). | 20 which will generate this file (Comments are not preserved). |
| 21 Note: PRODUCT_DIR will be substituted at run-time with actual | 21 Note: PRODUCT_DIR will be substituted at run-time with actual |
| 22 directory path (e.g. out/Debug) | 22 directory path (e.g. out/Debug) |
| 23 --> | 23 --> |
| 24 <issue id="AllowBackup"> | |
| 25 <ignore path="AndroidManifest.xml"/> | |
| 26 </issue> | |
| 27 <issue id="CommitPrefEdits"> | |
| 28 <ignore path="third_party/cacheinvalidation/src/java/com/google/ipc/invalida tion/ticl/android2/channel/AndroidChannelPreferences.java"/> | |
| 29 </issue> | |
| 30 <issue id="DefaultLocale"> | |
|
boliu
2014/01/09 20:57:47
I actually think this is a good check. Now we can
| |
| 31 <ignore path="PRODUCT_DIR/content_shell_test_apk/classes/org/chromium/conten t/browser/ViewportTest.class"/> | |
| 32 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/net/spdypr oxy/DataReductionProxySettings.java"/> | |
| 33 <ignore path="chrome/android/testshell/javatests/src/org/chromium/chrome/tes tshell/ChromiumTestShellUrlTest.java"/> | |
| 34 <ignore path="chrome/test/android/javatests/src/org/chromium/chrome/test/uti l/browser/sync/SyncTestUtil.java"/> | |
| 35 <ignore path="content/public/android/java/src/org/chromium/content/app/Linke r.java"/> | |
| 36 <ignore path="content/public/android/java/src/org/chromium/content/browser/L oadUrlParams.java"/> | |
| 37 <ignore path="content/public/android/java/src/org/chromium/content/browser/a ccessibility/JellyBeanAccessibilityInjector.java"/> | |
| 38 <ignore path="content/public/android/javatests/src/org/chromium/content/brow ser/ViewportTest.java"/> | |
| 39 <ignore path="third_party/cacheinvalidation/src/java/com/google/ipc/invalida tion/external/client/contrib/AndroidListenerState.java"/> | |
| 40 </issue> | |
| 41 <issue id="DrawAllocation"> | |
| 42 <ignore path="content/public/android/java/src/org/chromium/content/browser/C ontentViewRenderView.java"/> | |
| 43 <ignore path="content/public/android/java/src/org/chromium/content/browser/P opupZoomer.java"/> | |
| 44 </issue> | |
| 45 <issue id="ExportedContentProvider"> | |
| 46 <ignore path="AndroidManifest.xml"/> | |
| 47 </issue> | |
| 48 <issue id="HandlerLeak"> | |
| 49 <ignore path="content/public/android/java/src/org/chromium/content/browser/L ongPressDetector.java"/> | |
| 50 <ignore path="content/public/android/java/src/org/chromium/content/browser/t hird_party/GestureDetector.java"/> | |
| 51 <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDe tector.java"/> | |
| 52 </issue> | |
| 53 <issue id="InlinedApi"> | |
| 54 <ignore path="base/android/java/src/org/chromium/base/ApiCompatibilityUtils. java"/> | |
| 55 <ignore path="base/android/java/src/org/chromium/base/MemoryPressureListener .java"/> | |
| 56 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/printing/P rintingControllerFactory.java"/> | |
| 57 <ignore path="content/public/android/java/src/org/chromium/content/browser/D eviceUtils.java"/> | |
| 58 <ignore path="content/public/android/java/src/org/chromium/content/browser/a ccessibility/BrowserAccessibilityManager.java"/> | |
| 59 <ignore path="content/public/android/java/src/org/chromium/content/browser/a ccessibility/JellyBeanAccessibilityInjector.java"/> | |
| 60 <ignore path="media/base/android/java/src/org/chromium/media/AudioManagerAnd roid.java"/> | |
| 61 <ignore path="media/base/android/java/src/org/chromium/media/MediaCodecBridg e.java"/> | |
| 62 <ignore path="media/base/android/java/src/org/chromium/media/MediaDrmBridge. java"/> | |
| 63 <ignore path="media/base/android/java/src/org/chromium/media/WebAudioMediaCo decBridge.java"/> | |
| 64 <ignore path="net/android/java/src/org/chromium/net/X509Util.java"/> | |
| 65 <ignore path="printing/android/java/src/org/chromium/printing/PrintingContro llerImpl.java"/> | |
| 66 <ignore path="ui/android/java/src/org/chromium/ui/base/LocalizationUtils.jav a"/> | |
| 67 </issue> | |
| 68 <issue id="MissingRegistered" severity="ignore"/> | 24 <issue id="MissingRegistered" severity="ignore"/> |
| 69 <issue id="MissingSuperCall"> | 25 <issue id="MissingSuperCall"> |
| 70 <ignore path="android_webview/java/src/org/chromium/android_webview/AwConten ts.java"/> | |
| 71 <ignore path="content/public/android/java/src/org/chromium/content/browser/C ontentViewCore.java"/> | 26 <ignore path="content/public/android/java/src/org/chromium/content/browser/C ontentViewCore.java"/> |
| 72 </issue> | 27 </issue> |
| 73 <issue id="MissingVersion"> | |
| 74 <ignore path="AndroidManifest.xml"/> | |
| 75 </issue> | |
| 76 <issue id="NewApi"> | 28 <issue id="NewApi"> |
| 77 <ignore path="PRODUCT_DIR/chromium_testshell_test_apk/classes/org/chromium/p rinting/PrintingControllerTest$6.class"/> | 29 <ignore path="PRODUCT_DIR/chromium_testshell_test_apk/classes/org/chromium/p rinting/PrintingControllerTest$6.class"/> |
| 30 <ignore path="PRODUCT_DIR/chromium_testshell_test_apk/classes/org/chromium/p rinting/PrintingControllerTest$7.class"/> | |
| 78 <ignore path="PRODUCT_DIR/chromium_testshell_test_apk/classes/org/chromium/p rinting/PrintingControllerTest.class"/> | 31 <ignore path="PRODUCT_DIR/chromium_testshell_test_apk/classes/org/chromium/p rinting/PrintingControllerTest.class"/> |
| 79 <ignore path="PRODUCT_DIR/content_shell_test_apk/classes/org/chromium/conten t/browser/ClipboardTest.class"/> | 32 <ignore path="PRODUCT_DIR/content_shell_test_apk/classes/org/chromium/conten t/browser/ClipboardTest.class"/> |
| 80 <ignore path="android_webview/java/src/org/chromium/android_webview/AwPdfExp orter.java"/> | 33 <ignore path="android_webview/java/src/org/chromium/android_webview/AwPdfExp orter.java"/> |
| 81 <ignore path="android_webview/java/src/org/chromium/android_webview/AwPrintD ocumentAdapter.java"/> | 34 <ignore path="android_webview/java/src/org/chromium/android_webview/AwPrintD ocumentAdapter.java"/> |
| 82 <ignore path="android_webview/java/src/org/chromium/android_webview/AwWebCon tentsDelegateAdapter.java"/> | 35 <ignore path="android_webview/java/src/org/chromium/android_webview/AwWebCon tentsDelegateAdapter.java"/> |
| 83 <ignore path="android_webview/test/shell/src/org/chromium/android_webview/te st/AwTestContainerView.java"/> | 36 <ignore path="android_webview/test/shell/src/org/chromium/android_webview/te st/AwTestContainerView.java"/> |
| 84 <ignore path="base/android/java/src/org/chromium/base/ApiCompatibilityUtils. java"/> | 37 <ignore path="base/android/java/src/org/chromium/base/ApiCompatibilityUtils. java"/> |
| 85 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/BookmarkUt ils.java"/> | 38 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/BookmarkUt ils.java"/> |
| 86 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/TtsPlatfor mImpl.java"/> | 39 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/TtsPlatfor mImpl.java"/> |
| 87 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/appmenu/Ap pMenu.java"/> | 40 <ignore path="chrome/android/java/src/org/chromium/chrome/browser/appmenu/Ap pMenu.java"/> |
| (...skipping 14 matching lines...) Expand all Loading... | |
| 102 <ignore path="media/base/android/java/src/org/chromium/media/MediaDrmBridge. java"/> | 55 <ignore path="media/base/android/java/src/org/chromium/media/MediaDrmBridge. java"/> |
| 103 <ignore path="media/base/android/java/src/org/chromium/media/VideoCapture.ja va"/> | 56 <ignore path="media/base/android/java/src/org/chromium/media/VideoCapture.ja va"/> |
| 104 <ignore path="media/base/android/java/src/org/chromium/media/WebAudioMediaCo decBridge.java"/> | 57 <ignore path="media/base/android/java/src/org/chromium/media/WebAudioMediaCo decBridge.java"/> |
| 105 <ignore path="printing/android/java/src/org/chromium/printing/PrintDocumentA dapterWrapper.java"/> | 58 <ignore path="printing/android/java/src/org/chromium/printing/PrintDocumentA dapterWrapper.java"/> |
| 106 <ignore path="printing/android/java/src/org/chromium/printing/PrintManagerDe legateImpl.java"/> | 59 <ignore path="printing/android/java/src/org/chromium/printing/PrintManagerDe legateImpl.java"/> |
| 107 <ignore path="printing/android/java/src/org/chromium/printing/PrintingContro llerImpl.java"/> | 60 <ignore path="printing/android/java/src/org/chromium/printing/PrintingContro llerImpl.java"/> |
| 108 <ignore path="tools/android/memconsumer/java/src/org/chromium/memconsumer/Re sidentService.java"/> | 61 <ignore path="tools/android/memconsumer/java/src/org/chromium/memconsumer/Re sidentService.java"/> |
| 109 <ignore path="ui/android/java/src/org/chromium/ui/ColorPickerAdvancedCompone nt.java"/> | 62 <ignore path="ui/android/java/src/org/chromium/ui/ColorPickerAdvancedCompone nt.java"/> |
| 110 <ignore path="ui/android/java/src/org/chromium/ui/base/Clipboard.java"/> | 63 <ignore path="ui/android/java/src/org/chromium/ui/base/Clipboard.java"/> |
| 111 <ignore path="ui/android/java/src/org/chromium/ui/base/LocalizationUtils.jav a"/> | 64 <ignore path="ui/android/java/src/org/chromium/ui/base/LocalizationUtils.jav a"/> |
| 65 <ignore path="ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java "/> | |
| 112 <ignore path="ui/android/java/src/org/chromium/ui/gl/SurfaceTexturePlatformW rapper.java"/> | 66 <ignore path="ui/android/java/src/org/chromium/ui/gl/SurfaceTexturePlatformW rapper.java"/> |
| 113 </issue> | 67 </issue> |
| 114 <issue id="OldTargetApi"> | |
| 115 <ignore path="AndroidManifest.xml"/> | |
| 116 </issue> | |
| 117 <issue id="Recycle" severity="Error"> | |
| 118 <ignore path="PRODUCT_DIR/content_shell_test_apk/classes/org/chromium/conten t/browser/ContentViewGestureHandlerTest.class"/> | |
| 119 <ignore path="android_webview/javatests/src/org/chromium/android_webview/tes t/WebKitHitTestTest.java"/> | |
| 120 <ignore path="android_webview/javatests/src/org/chromium/android_webview/tes t/util/AwTestTouchUtils.java"/> | |
| 121 <ignore path="chrome/android/javatests/src/org/chromium/chrome/browser/test/ ProviderBookmarkNodeTest.java"/> | |
| 122 <ignore path="content/public/test/android/javatests/src/org/chromium/content /browser/test/util/TestTouchUtils.java"/> | |
| 123 <ignore path="content/public/test/android/javatests/src/org/chromium/content /browser/test/util/TouchCommon.java"/> | |
| 124 </issue> | |
| 125 <issue id="Registered" severity="ignore"/> | |
| 126 <issue id="SdCardPath"> | |
| 127 <ignore path="content/public/android/java/src/org/chromium/content/browser/M ediaResourceGetter.java"/> | |
| 128 </issue> | |
| 129 <issue id="SetJavaScriptEnabled" severity="ignore"/> | |
| 130 <issue id="UseSparseArrays"> | |
| 131 <ignore path="android_webview/java/src/org/chromium/android_webview/AwResour ce.java"/> | |
| 132 <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDe tector.java"/> | |
| 133 <ignore path="ui/android/java/src/org/chromium/ui/base/WindowAndroid.java"/> | |
| 134 </issue> | |
| 135 <issue id="ViewConstructor" severity="ignore"/> | |
| 136 <issue id="WrongCall" severity="ignore"/> | 68 <issue id="WrongCall" severity="ignore"/> |
| 137 </lint> | 69 </lint> |
| OLD | NEW |