Win Video Capture: Sending the timestamps provided by the driver to the capture pipeline

media/capture/video/win/sink_input_pin_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/capture/video/win/sink_input_pin_win.h"
 
 #include <cstring>
 
 // Avoid including strsafe.h via dshow as it will cause build warnings.
 #define NO_DSHOW_STRSAFE
@@ skipping 164 matching lines @@
   uint8* buffer = NULL;
 
   if (length <= 0) {
     DLOG(WARNING) << "Media sample length is 0 or less.";
     return S_FALSE;
   }
 
   if (FAILED(sample->GetPointer(&buffer)))
     return S_FALSE;
 
-  observer_->FrameReceived(buffer, length);
+  REFERENCE_TIME start_time, end_time;
+

[mcasas, 2015/09/10 20:03:20]

no blank line

[qiangchen, 2015/09/10 21:37:45]

Done.

+  if (FAILED(sample->GetTime(&start_time, &end_time))) {
+    start_time = -1;
+    end_time = -1;

[mcasas, 2015/09/10 20:03:20]

Hmmm, the assignment and the use of |start_time| are a bit far now 
and that dilutes your original intention.

I suggest you change the interface signature of FrameReceived() to
 
void FrameReceived(const uint8* , int , base::TimeTicks)

and do all the calculations here:

REFERENCE_TIME start_time, end_time;
base::TimeTicks capture_timestamp;
if (SUCCEEDED(sample->GetTime(&start_time, &end_time))) {
  DCHECK_LE(start_time, end_time);
  capture_timestamp += base::TimeDelta::FromMicroseconds(start_time / 10);
} else {
  capture_timestamp = base::TimeTicks::Now();
}
observer_->FrameReceived(buffer, length, capture_timestamp);

Like this is clearer what is sent as timestamp and why.
WDYT?

[qiangchen, 2015/09/10 21:37:45]

Done.

+  }
+
+  DCHECK(start_time <= end_time);
+
+  observer_->FrameReceived(buffer, length, start_time);
   return S_OK;
 }
 
 SinkInputPin::~SinkInputPin() {
 }
 
 }  // namespace media