build/android/pylib/system_properties.py - Issue 132463007: Enable presubmit pylint in build/android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/system_properties.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/system_properties.py

diff --git a/build/android/pylib/system_properties.py b/build/android/pylib/system_properties.py

index ce5d617d73b4e4c6bb23ee570d3bf89e40d5fe1d..3f16f86e77b8f19862b37187686353d8912d43ee 100644

--- a/build/android/pylib/system_properties.py

+++ b/build/android/pylib/system_properties.py

@@ -29,7 +29,8 @@ class SystemProperties(dict):

# TODO(tonyg): This can fail with no root. Verify that it succeeds.

self._adb.SendShellCommand('setprop %s "%s"' % (key, value), retry_count=3)

- def _IsStatic(self, key):

+ @staticmethod

+ def _IsStatic(key):

# TODO(tonyg): This list is conservative and could be expanded as needed.

return (key.startswith('ro.boot.') or

key.startswith('ro.build.') or

« no previous file with comments | « build/android/pylib/screenshot.py ('k') | build/android/pylib/uiautomator/setup.py » ('j') | no next file with comments »