Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1858)

Unified Diff: build/android/pylib/base/test_dispatcher_unittest.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/base/test_dispatcher.py ('k') | build/android/pylib/chrome_test_server_spawner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/base/test_dispatcher_unittest.py
diff --git a/build/android/pylib/base/test_dispatcher_unittest.py b/build/android/pylib/base/test_dispatcher_unittest.py
index c6078dbdfcfca6f0bb433067139f8158cd181920..1409b5bbc8cc04da526456ddd39ba670c7a371be 100644
--- a/build/android/pylib/base/test_dispatcher_unittest.py
+++ b/build/android/pylib/base/test_dispatcher_unittest.py
@@ -3,6 +3,8 @@
# found in the LICENSE file.
"""Unittests for test_dispatcher.py."""
+# pylint: disable=R0201
+# pylint: disable=W0212
import os
import sys
@@ -15,10 +17,10 @@ sys.path.append(os.path.join(os.path.dirname(os.path.realpath(__file__)),
from pylib import android_commands
android_commands.GetAttachedDevices = lambda: ['0', '1']
from pylib import constants
+from pylib.base import base_test_result
+from pylib.base import test_dispatcher
from pylib.utils import watchdog_timer
-import base_test_result
-import test_dispatcher
class TestException(Exception):
@@ -191,7 +193,7 @@ class TestShard(unittest.TestCase):
android_commands.GetAttachedDevices = lambda: []
try:
with self.assertRaises(AssertionError):
- results, exit_code = TestShard._RunShard(MockRunner)
+ _results, _exit_code = TestShard._RunShard(MockRunner)
finally:
android_commands.GetAttachedDevices = attached_devices
« no previous file with comments | « build/android/pylib/base/test_dispatcher.py ('k') | build/android/pylib/chrome_test_server_spawner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698