Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4331)

Unified Diff: build/android/gyp/emma_instr.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/dex.py ('k') | build/android/gyp/finalize_apk.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/emma_instr.py
diff --git a/build/android/gyp/emma_instr.py b/build/android/gyp/emma_instr.py
index 8d97ed38ae1c6030fa69ad936626b7843cfc91e3..b043c29a83669cd766d82848df2548c1c238677c 100755
--- a/build/android/gyp/emma_instr.py
+++ b/build/android/gyp/emma_instr.py
@@ -29,7 +29,7 @@ import tempfile
sys.path.append(os.path.join(os.path.dirname(__file__), os.pardir))
from pylib.utils import command_option_parser
-from util import build_utils
+from util import build_utils # pylint: disable=F0401
def _AddCommonOptions(option_parser):
@@ -63,7 +63,7 @@ def _AddInstrumentOptions(option_parser):
'patterns separated with whitespace and/or comma.'))
-def _RunCopyCommand(command, options, args, option_parser):
+def _RunCopyCommand(_command, options, _, option_parser):
"""Copies the jar from input to output locations.
Also removes any old coverage/sources file.
@@ -129,7 +129,7 @@ def _CreateSourcesFile(sources_string, sources_file, src_root):
json.dump(relative_sources, f)
-def _RunInstrumentCommand(command, options, args, option_parser):
+def _RunInstrumentCommand(command, options, _, option_parser):
"""Instruments the classes/jar files using EMMA.
Args:
@@ -197,11 +197,11 @@ VALID_COMMANDS = {
}
-def main(argv):
+def main():
option_parser = command_option_parser.CommandOptionParser(
commands_dict=VALID_COMMANDS)
command_option_parser.ParseAndExecute(option_parser)
if __name__ == '__main__':
- sys.exit(main(sys.argv))
+ sys.exit(main())
« no previous file with comments | « build/android/gyp/dex.py ('k') | build/android/gyp/finalize_apk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698