Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: build/android/generate_emma_html.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/findbugs_diff.py ('k') | build/android/gyp/ant.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/generate_emma_html.py
diff --git a/build/android/generate_emma_html.py b/build/android/generate_emma_html.py
index 463a83687c269fd46fdc2e8a9fa31e5f2c2bdcba..93b0b0e59c5b10eafa3b3c0a97e3d9ebd081f434 100755
--- a/build/android/generate_emma_html.py
+++ b/build/android/generate_emma_html.py
@@ -11,7 +11,6 @@ import json
import optparse
import os
import sys
-import traceback
from pylib import cmd_helper
from pylib import constants
@@ -36,7 +35,7 @@ def _GetFilesWithExt(root_dir, ext):
return files
-def main(argv):
+def main():
option_parser = optparse.OptionParser()
option_parser.add_option('--output', help='HTML output filename.')
option_parser.add_option('--coverage-dir', default=None,
@@ -48,7 +47,7 @@ def main(argv):
option_parser.add_option('--cleanup', action='store_true',
help=('If set, removes coverage files generated at '
'runtime.'))
- options, args = option_parser.parse_args()
+ options, _ = option_parser.parse_args()
if not (options.coverage_dir and options.metadata_dir and options.output):
option_parser.error('One or more mandatory options are missing.')
@@ -88,4 +87,4 @@ def main(argv):
if __name__ == '__main__':
- sys.exit(main(sys.argv))
+ sys.exit(main())
« no previous file with comments | « build/android/findbugs_diff.py ('k') | build/android/gyp/ant.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698