build/android/adb_logcat_monitor.py - Issue 132463007: Enable presubmit pylint in build/android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/adb_logcat_monitor.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/adb_logcat_monitor.py

diff --git a/build/android/adb_logcat_monitor.py b/build/android/adb_logcat_monitor.py

index 35ef7905b24fcb9a30506f5e0d246d3f52085214..6e1a68940b0068ae24e8294f90424a8b5cb682fe 100755

--- a/build/android/adb_logcat_monitor.py

+++ b/build/android/adb_logcat_monitor.py

@@ -108,12 +108,12 @@ def main(base_dir, adb_cmd='adb'):

# Set up the alarm for calling 'adb devices'. This is to ensure

# our script doesn't get stuck waiting for a process response

- def TimeoutHandler(_, unused_frame):

+ def TimeoutHandler(_, _):

raise TimeoutException()

signal.signal(signal.SIGALRM, TimeoutHandler)

# Handle SIGTERMs to ensure clean shutdown

- def SigtermHandler(_, unused_frame):

+ def SigtermHandler(_, _):

raise SigtermError()

signal.signal(signal.SIGTERM, SigtermHandler)

« no previous file with comments | « build/android/PRESUBMIT.py ('k') | build/android/adb_logcat_printer.py » ('j') | no next file with comments »