Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1877)

Unified Diff: build/android/avd.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/avd.py
diff --git a/build/android/avd.py b/build/android/avd.py
index d9cb82c7de32f84f5e64bf94eb899b5517dab0f4..71c8eb393bf9259490856e275c78dac20fe43d4c 100755
--- a/build/android/avd.py
+++ b/build/android/avd.py
@@ -13,7 +13,6 @@ import install_emulator_deps
import logging
import optparse
import os
-import subprocess
import sys
from pylib import constants
@@ -36,7 +35,7 @@ def main(argv):
help='API level for the image, e.g. 19 for Android 4.4',
type='int', default=constants.ANDROID_SDK_VERSION)
- options, _ = opt_parser.parse_args(argv[1:])
+ options, _args = opt_parser.parse_args(argv[1:])
frankf 2014/02/03 18:58:51 why was this an issue? The orignal was more readab
jbudorick 2014/02/03 19:33:57 This was not an issue for pylint. I just wanted to
logging.basicConfig(level=logging.INFO,
format='# %(asctime)-15s: %(message)s')
@@ -45,7 +44,7 @@ def main(argv):
# Check if KVM is enabled for x86 AVD's and check for x86 system images.
# TODO(andrewhayden) Since we can fix all of these with install_emulator_deps
# why don't we just run it?
- if options.abi =='x86':
+ if options.abi == 'x86':
if not install_emulator_deps.CheckKVM():
logging.critical('ERROR: KVM must be enabled in BIOS, and installed. '
'Enable KVM in BIOS and run install_emulator_deps.py')

Powered by Google App Engine
This is Rietveld 408576698