Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: build/android/pylib/linker/setup.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Setup for linker tests.""" 5 """Setup for linker tests."""
6 6
7 import os 7 import os
8 import sys 8 import sys
9 import types
10
11 import test_case
12 import test_runner
13 9
14 from pylib import constants 10 from pylib import constants
11 from pylib.linker import test_case
12 from pylib.linker import test_runner
15 13
16 sys.path.insert(0, 14 sys.path.insert(0,
17 os.path.join(constants.DIR_SOURCE_ROOT, 'build', 'util', 'lib', 15 os.path.join(constants.DIR_SOURCE_ROOT, 'build', 'util', 'lib',
18 'common')) 16 'common'))
19 import unittest_util 17 import unittest_util # pylint: disable=F0401
20 18
21 def Setup(options, devices): 19 def Setup(options, _devices):
22 """Creates a list of test cases and a runner factory. 20 """Creates a list of test cases and a runner factory.
23 21
24 Returns: 22 Returns:
25 A tuple of (TestRunnerFactory, tests). 23 A tuple of (TestRunnerFactory, tests).
26 """ 24 """
27 test_cases = [ 25 test_cases = [
28 test_case.LinkerLibraryAddressTest, 26 test_case.LinkerLibraryAddressTest,
29 test_case.LinkerSharedRelroTest, 27 test_case.LinkerSharedRelroTest,
30 test_case.LinkerRandomizationTest ] 28 test_case.LinkerRandomizationTest ]
31 29
32 low_memory_modes = [False, True] 30 low_memory_modes = [False, True]
33 all_tests = [t(is_low_memory=m) for t in test_cases for m in low_memory_modes] 31 all_tests = [t(is_low_memory=m) for t in test_cases for m in low_memory_modes]
34 32
35 if options.test_filter: 33 if options.test_filter:
36 all_test_names = [ test.qualified_name for test in all_tests ] 34 all_test_names = [ test.qualified_name for test in all_tests ]
37 filtered_test_names = unittest_util.FilterTestNames(all_test_names, 35 filtered_test_names = unittest_util.FilterTestNames(all_test_names,
38 options.test_filter) 36 options.test_filter)
39 all_tests = [t for t in all_tests \ 37 all_tests = [t for t in all_tests \
40 if t.qualified_name in filtered_test_names] 38 if t.qualified_name in filtered_test_names]
41 39
42 def TestRunnerFactory(device, shard_index): 40 def TestRunnerFactory(device, _shard_index):
43 return test_runner.LinkerTestRunner( 41 return test_runner.LinkerTestRunner(
44 device, options.tool, options.push_deps, 42 device, options.tool, options.push_deps,
45 options.cleanup_test_files) 43 options.cleanup_test_files)
46 44
47 return (TestRunnerFactory, all_tests) 45 return (TestRunnerFactory, all_tests)
OLDNEW
« no previous file with comments | « build/android/pylib/instrumentation/test_runner.py ('k') | build/android/pylib/linker/test_case.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698