Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: build/android/gyp/proguard.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase vs tot and only disabling F0401 in specific spots Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/gyp/process_resources.py ('k') | build/android/gyp/push_libraries.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2013 The Chromium Authors. All rights reserved. 3 # Copyright 2013 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 import fnmatch
8 import optparse 7 import optparse
9 import os 8 import os
10 import sys 9 import sys
11 10
12 from util import build_utils 11 from util import build_utils # pylint: disable=F0401
13 12
14 def DoProguard(options): 13 def DoProguard(options):
15 injars = options.input_path 14 injars = options.input_path
16 outjars = options.output_path 15 outjars = options.output_path
17 classpath = build_utils.ParseGypList(options.classpath) 16 classpath = build_utils.ParseGypList(options.classpath)
18 classpath = list(set(classpath)) 17 classpath = list(set(classpath))
19 libraryjars = ':'.join(classpath) 18 libraryjars = ':'.join(classpath)
20 # proguard does its own dependency checking, which can be avoided by deleting 19 # proguard does its own dependency checking, which can be avoided by deleting
21 # the output. 20 # the output.
22 if os.path.exists(options.output_path): 21 if os.path.exists(options.output_path):
23 os.remove(options.output_path) 22 os.remove(options.output_path)
24 proguard_cmd = [options.proguard_path, 23 proguard_cmd = [options.proguard_path,
25 '-injars', injars, 24 '-injars', injars,
26 '-outjars', outjars, 25 '-outjars', outjars,
27 '-libraryjars', libraryjars, 26 '-libraryjars', libraryjars,
28 '@' + options.proguard_config] 27 '@' + options.proguard_config]
29 build_utils.CheckOutput(proguard_cmd, print_stdout=True) 28 build_utils.CheckOutput(proguard_cmd, print_stdout=True)
30 29
31 30
32 def main(argv): 31 def main():
33 parser = optparse.OptionParser() 32 parser = optparse.OptionParser()
34 parser.add_option('--proguard-path', 33 parser.add_option('--proguard-path',
35 help='Path to the proguard executable.') 34 help='Path to the proguard executable.')
36 parser.add_option('--input-path', 35 parser.add_option('--input-path',
37 help='Path to the .jar file proguard should run on.') 36 help='Path to the .jar file proguard should run on.')
38 parser.add_option('--output-path', help='Path to the generated .jar file.') 37 parser.add_option('--output-path', help='Path to the generated .jar file.')
39 parser.add_option('--proguard-config', 38 parser.add_option('--proguard-config',
40 help='Path to the proguard configuration file.') 39 help='Path to the proguard configuration file.')
41 parser.add_option('--classpath', help="Classpath for proguard.") 40 parser.add_option('--classpath', help="Classpath for proguard.")
42 parser.add_option('--stamp', help='Path to touch on success.') 41 parser.add_option('--stamp', help='Path to touch on success.')
43 42
44 # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja. 43 # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja.
45 parser.add_option('--ignore', help='Ignored.') 44 parser.add_option('--ignore', help='Ignored.')
46 45
47 options, _ = parser.parse_args() 46 options, _ = parser.parse_args()
48 47
49 DoProguard(options) 48 DoProguard(options)
50 49
51 if options.stamp: 50 if options.stamp:
52 build_utils.Touch(options.stamp) 51 build_utils.Touch(options.stamp)
53 52
54 53
55 if __name__ == '__main__': 54 if __name__ == '__main__':
56 sys.exit(main(sys.argv)) 55 sys.exit(main())
OLDNEW
« no previous file with comments | « build/android/gyp/process_resources.py ('k') | build/android/gyp/push_libraries.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698