Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Side by Side Diff: build/android/gyp/get_device_configuration.py

Issue 132463007: Enable presubmit pylint in build/android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address frankf review comments. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2013 The Chromium Authors. All rights reserved. 3 # Copyright 2013 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """Gets and writes the configurations of the attached devices. 7 """Gets and writes the configurations of the attached devices.
8 8
9 This configuration is used by later build steps to determine which devices to 9 This configuration is used by later build steps to determine which devices to
10 install to and what needs to be installed to those devices. 10 install to and what needs to be installed to those devices.
11 """ 11 """
12 12
13 import logging
14 import optparse 13 import optparse
15 import os 14 import os
16 import subprocess
17 import sys 15 import sys
18 16
19 from util import build_utils 17 from util import build_utils
20 from util import build_device 18 from util import build_device
21 19
22 BUILD_ANDROID_DIR = os.path.join(os.path.dirname(__file__), '..') 20 BUILD_ANDROID_DIR = os.path.join(os.path.dirname(__file__), '..')
23 sys.path.append(BUILD_ANDROID_DIR) 21 sys.path.append(BUILD_ANDROID_DIR)
24 22
25 from pylib.utils import apk_helper
26
27 23
28 def main(argv): 24 def main(argv):
29 parser = optparse.OptionParser() 25 parser = optparse.OptionParser()
30 parser.add_option('--stamp', action='store') 26 parser.add_option('--stamp', action='store')
31 parser.add_option('--output', action='store') 27 parser.add_option('--output', action='store')
32 options, _ = parser.parse_args(argv) 28 options, _ = parser.parse_args(argv)
33 29
34 devices = build_device.GetAttachedDevices() 30 devices = build_device.GetAttachedDevices()
35 31
36 device_configurations = [] 32 device_configurations = []
(...skipping 29 matching lines...) Expand all
66 'Multiple devices attached. ' 62 'Multiple devices attached. '
67 'Installing to the preferred device: ' 63 'Installing to the preferred device: '
68 '%(id)s (%(description)s)' % (device_configurations[0])) 64 '%(id)s (%(description)s)' % (device_configurations[0]))
69 65
70 66
71 build_device.WriteConfigurations(device_configurations, options.output) 67 build_device.WriteConfigurations(device_configurations, options.output)
72 68
73 69
74 if __name__ == '__main__': 70 if __name__ == '__main__':
75 sys.exit(main(sys.argv)) 71 sys.exit(main(sys.argv))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698