tools/clang/plugins/FindBadConstructs.cpp - Issue 132463005: Clang plugin: fix TypeHasNonTrivialDtor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/FindBadConstructs.cpp

Issue 132463005: Clang plugin: fix TypeHasNonTrivialDtor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/plugins/FindBadConstructs.cpp

diff --git a/tools/clang/plugins/FindBadConstructs.cpp b/tools/clang/plugins/FindBadConstructs.cpp

index bdc497f64de99a0cad815473c6998195a88c52c0..c8d166e38dbf53a986b24e2e3c1f5562637b8acd 100644

--- a/tools/clang/plugins/FindBadConstructs.cpp

+++ b/tools/clang/plugins/FindBadConstructs.cpp

@@ -59,7 +59,7 @@ const char kNoteProtectedNonVirtualDtor[] =

bool TypeHasNonTrivialDtor(const Type* type) {

if (const CXXRecordDecl* cxx_r = type->getPointeeCXXRecordDecl())

- return cxx_r->hasTrivialDestructor();

+ return !cxx_r->hasTrivialDestructor();

return false;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »