Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: third_party/brotli/BUILD.gn

Issue 1324623005: Move sanitizer and symbol flags out of BUILDCONFIG (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/boringssl/BUILD.gn ('k') | third_party/opus/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("brotli_warnings") { 5 config("brotli_warnings") {
6 if (is_clang) { 6 if (is_clang) {
7 # IncrementalCopyFastPath in decode.c can be unused. 7 # IncrementalCopyFastPath in decode.c can be unused.
8 # (The file looks very different upstream, this is probably no longer 8 # (The file looks very different upstream, this is probably no longer
9 # needed after rolling brotli the next time.) 9 # needed after rolling brotli the next time.)
10 cflags = [ "-Wno-unused-function" ] 10 cflags = [ "-Wno-unused-function" ]
(...skipping 23 matching lines...) Expand all
34 34
35 configs -= [ "//build/config/compiler:chromium_code" ] 35 configs -= [ "//build/config/compiler:chromium_code" ]
36 configs += [ 36 configs += [
37 "//build/config/compiler:no_chromium_code", 37 "//build/config/compiler:no_chromium_code",
38 38
39 # Must be after no_chromium_code for warning flags to be ordered correctly. 39 # Must be after no_chromium_code for warning flags to be ordered correctly.
40 ":brotli_warnings", 40 ":brotli_warnings",
41 ] 41 ]
42 42
43 # Since we are never debug brotli, freeze the optimizations to -O2. 43 # Since we are never debug brotli, freeze the optimizations to -O2.
44 if (is_debug) { 44 configs -= [ "//build/config/compiler:default_optimization" ]
45 configs -= [ "//build/config/compiler:no_optimize" ]
46 } else {
47 configs -= [ "//build/config/compiler:optimize" ]
48 }
49 configs += [ "//build/config/compiler:optimize_max" ] 45 configs += [ "//build/config/compiler:optimize_max" ]
50 46
51 include_dirs = [ "dec" ] 47 include_dirs = [ "dec" ]
52 } 48 }
OLDNEW
« no previous file with comments | « third_party/boringssl/BUILD.gn ('k') | third_party/opus/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698