Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 13246: Experimental: more code generator changes.... (Closed)

Created:
12 years ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
iposva, William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Experimental: more code generator changes. 1. Enable virtual frame/register allocator for for loops. 2. Spill all registers before the stack check code. We were always spilled before simply due to it being the function entry. Now that we handle for loops, that is not necessarily the case. 3. Label blocks first reached via JumpTarget::Bind with a 'mergable' frame in case they are the later target of a backward CFG edge. We didn't have non-spilled code at backward CFG edges before. 4. Avoid generating a branch to a jump for JumpTarget::Branch in the case that there is no code necessary to make the expected frame mergable. 5. Remove some overzealous spilling. Committed: http://code.google.com/p/v8/source/detail?r=951

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -48 lines) Patch
M src/assembler-ia32.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M src/codegen-ia32.h View 1 chunk +4 lines, -5 lines 0 comments Download
M src/codegen-ia32.cc View 1 2 25 chunks +57 lines, -14 lines 0 comments Download
M src/jump-target-ia32.cc View 1 2 4 chunks +29 lines, -14 lines 0 comments Download
M src/virtual-frame-ia32.h View 1 2 3 chunks +20 lines, -1 line 0 comments Download
M src/virtual-frame-ia32.cc View 1 2 6 chunks +86 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
This change includes my previous one. Take a look at this one instead if you ...
12 years ago (2008-12-08 14:40:48 UTC) #1
Kevin Millikin (Chromium)
I've uploaded a new patch set that fixes a bug in the previous one. After ...
12 years ago (2008-12-09 09:51:45 UTC) #2
William Hesse
12 years ago (2008-12-09 12:35:42 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698