chrome/browser/resources/file_manager/foreground/js/file_manager_commands.js - Issue 132453007: Migrate fullPaths to URLs in appState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/file_manager/foreground/js/file_manager_commands.js

Issue 132453007: Migrate fullPaths to URLs in appState. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/file_manager/background/js/background.js ('K') | « chrome/browser/resources/file_manager/foreground/js/file_manager.js ('k') | chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/file_manager/foreground/js/file_manager_commands.js

diff --git a/chrome/browser/resources/file_manager/foreground/js/file_manager_commands.js b/chrome/browser/resources/file_manager/foreground/js/file_manager_commands.js

index f1b9a62b9629c1499ef0a1d4260d38e035f41152..2ce8be128375092678eb17ca054fab2d51748a01 100644

--- a/chrome/browser/resources/file_manager/foreground/js/file_manager_commands.js

+++ b/chrome/browser/resources/file_manager/foreground/js/file_manager_commands.js

@@ -460,10 +460,9 @@ CommandHandler.COMMANDS_['new-folder'] = {

CommandHandler.COMMANDS_['new-window'] = {

execute: function(event, fileManager) {

- // TODO(mtomasz): Use Entry.toURL() instead of fullPath.

fileManager.backgroundPage.launchFileManager({

- currentDirectoryPath: fileManager.getCurrentDirectoryEntry() &&

- fileManager.getCurrentDirectoryEntry().fullPath

+ currentDirectoryURL: fileManager.getCurrentDirectoryEntry() &&

+ fileManager.getCurrentDirectoryEntry().toURL

hirono 2014/01/27 05:39:56 toURL()

mtomasz 2014/01/27 06:12:52 Done.

});

canExecute: function(event, fileManager) {