Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: chrome/browser/resources/file_manager/foreground/js/file_manager_commands.js

Issue 132453007: Migrate fullPaths to URLs in appState. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 'use strict'; 5 'use strict';
6 6
7 /** 7 /**
8 * TODO(dzvorygin): Here we use this hack, since 'hidden' is standard 8 * TODO(dzvorygin): Here we use this hack, since 'hidden' is standard
9 * attribute and we can't use it's setter as usual. 9 * attribute and we can't use it's setter as usual.
10 * @param {boolean} value New value of hidden property. 10 * @param {boolean} value New value of hidden property.
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
453 !directoryModel.isScanning(); 453 !directoryModel.isScanning();
454 } 454 }
455 }; 455 };
456 456
457 /** 457 /**
458 * Initiates new window creation. 458 * Initiates new window creation.
459 * @type {Command} 459 * @type {Command}
460 */ 460 */
461 CommandHandler.COMMANDS_['new-window'] = { 461 CommandHandler.COMMANDS_['new-window'] = {
462 execute: function(event, fileManager) { 462 execute: function(event, fileManager) {
463 // TODO(mtomasz): Use Entry.toURL() instead of fullPath.
464 fileManager.backgroundPage.launchFileManager({ 463 fileManager.backgroundPage.launchFileManager({
465 currentDirectoryPath: fileManager.getCurrentDirectoryEntry() && 464 currentDirectoryURL: fileManager.getCurrentDirectoryEntry() &&
466 fileManager.getCurrentDirectoryEntry().fullPath 465 fileManager.getCurrentDirectoryEntry().toURL()
467 }); 466 });
468 }, 467 },
469 canExecute: function(event, fileManager) { 468 canExecute: function(event, fileManager) {
470 event.canExecute = 469 event.canExecute =
471 fileManager.getCurrentDirectoryEntry() && 470 fileManager.getCurrentDirectoryEntry() &&
472 (fileManager.dialogType === DialogType.FULL_PAGE); 471 (fileManager.dialogType === DialogType.FULL_PAGE);
473 } 472 }
474 }; 473 };
475 474
476 /** 475 /**
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
837 /** 836 /**
838 * Reset the zoom factor. 837 * Reset the zoom factor.
839 * @type {Command} 838 * @type {Command}
840 */ 839 */
841 CommandHandler.COMMANDS_['zoom-reset'] = { 840 CommandHandler.COMMANDS_['zoom-reset'] = {
842 execute: function(event, fileManager) { 841 execute: function(event, fileManager) {
843 chrome.fileBrowserPrivate.zoom('reset'); 842 chrome.fileBrowserPrivate.zoom('reset');
844 }, 843 },
845 canExecute: CommandUtil.canExecuteAlways 844 canExecute: CommandUtil.canExecuteAlways
846 }; 845 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698