Migrate fullPaths to URLs in appState.

chrome/test/data/extensions/api_test/file_manager_browsertest/test_cases.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @enum {string}
  * @const
  */
@@ skipping 201 matching lines @@
  * with "shared-with-me".
  *
  * @type {Array.<TestEntryInfo>}
  * @const
  */
 var SHARED_WITH_ME_ENTRY_SET = [
   ENTRIES.testSharedDocument
 ];
 
 /**
- * Opens a Files.app's main window and waits until it is initialized.
+ * Opens a Files.app's main window.
+ *
+ * TODO(mtomasz): Pass a volumeId or an enum value instead of full paths.
+ *
+ * @param {Object} appState App state to be passed with on opening Files.app.
+ *     Can be null.
+ * @param {?string} initialRoot Root path to be used as a default current
+ *     directory during initialization. Can be null, for no default path.
+ * @param {function(string)} Callback with the app id.
+ */
+function openNewWindow(appState, initialRoot, callback) {
+  var appId;
+
+  // TODO(mtomasz): Migrate from full paths to a pair of a volumeId and a
+  // relative path. To compose the URL communicate via messages with
+  // file_manager_browser_test.cc.
+  var processedAppState = appState || {};
+  if (initialRoot) {
+    processedAppState.currentDirectoryURL =
+        'filesystem:chrome-extension://' + FILE_MANAGER_EXTENSIONS_ID +
+        '/external' + initialRoot;
+  }
+
+  callRemoteTestUtil('openMainWindow', null, [processedAppState], callback);
+}
+
+/**
+ * Opens a Files.app's main window and waits until it is initialized. Fills
+ * the window with initial files. Should be called for the first window only.
  *
  * TODO(hirono): Add parameters to specify the entry set to be prepared.
+ * TODO(mtomasz): Pass a volumeId or an enum value instead of full paths.
  *
  * @param {Object} appState App state to be passed with on opening Files.app.
+ *     Can be null.
+ * @param {?string} initialRoot Root path to be used as a default current
+ *     directory during initialization. Can be null, for no default path.
  * @param {function(string, Array.<Array.<string>>)} Callback with the app id
  *     and with the file list.
  */
-function setupAndWaitUntilReady(appState, callback) {
+function setupAndWaitUntilReady(appState, initialRoot, callback) {
   var appId;
-  var steps = [
+
+  StepsRunner.run([
     function() {
-      callRemoteTestUtil('openMainWindow', null, [appState], steps.shift());
+      openNewWindow(appState, initialRoot, this.next);
     },
     function(inAppId) {
       appId = inAppId;
-      addEntries(['local'], BASIC_LOCAL_ENTRY_SET, steps.shift());
+      addEntries(['local'], BASIC_LOCAL_ENTRY_SET, this.next);
     },
     function(success) {
       chrome.test.assertTrue(success);
-      addEntries(['drive'], BASIC_DRIVE_ENTRY_SET, steps.shift());
+      addEntries(['drive'], BASIC_DRIVE_ENTRY_SET, this.next);
     },
     function(success) {
       chrome.test.assertTrue(success);
-      callRemoteTestUtil('waitForFileListChange', appId, [0], steps.shift());
+      callRemoteTestUtil('waitForFileListChange', appId, [0], this.next);
     },
     function(fileList) {
       callback(appId, fileList);
+      this.next();
     }
-  ];
-  steps.shift()();
+  ]);
 }
 
 /**
  * Verifies if there are no Javascript errors in any of the app windows.
  * @param {function()} Completion callback.
  */
 function checkIfNoErrorsOccured(callback) {
   callRemoteTestUtil('getErrorCount', null, [], function(count) {
     chrome.test.assertEq(0, count);
     callback();
   });
 }
 
-
-
 /**
  * Returns the name of the given file list entry.
  * @param {Array.<string>} file An entry in a file list.
  * @return {string} Name of the file.
  */
 function getFileName(fileListEntry) {
   return fileListEntry[0];
 }
 
 /**
@@ skipping 35 matching lines @@
 
   var expectedFilesBefore =
       TestEntryInfo.getExpectedRows(path == '/drive/root' ?
           BASIC_DRIVE_ENTRY_SET : BASIC_LOCAL_ENTRY_SET).sort();
 
   var expectedFilesAfter =
       expectedFilesBefore.concat([ENTRIES.newlyAdded.getExpectedRow()]).sort();
 
   StepsRunner.run([
     function() {
-      var appState = {currentDirectoryPath: path};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, path, this.next);
     },
     // Notify that the list has been verified and a new file can be added
     // in file_manager_browsertest.cc.
     function(inAppId, actualFilesBefore) {
       appId = inAppId;
       chrome.test.assertEq(expectedFilesBefore, actualFilesBefore);
       addEntries(['local', 'drive'], [ENTRIES.newlyAdded], this.next);
     },
     function(result) {
       chrome.test.assertTrue(result);
@@ skipping 14 matching lines @@
 /**
  * Tests if the gallery shows up for the selected image and that the image
  * gets displayed.
  *
  * @param {string} path Directory path to be tested.
  */
 testcase.intermediate.galleryOpen = function(path) {
   var appId;
   StepsRunner.run([
     function() {
-      var appState = {currentDirectoryPath: path};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, path, this.next);
     },
     // Resize the window to desired dimensions to avoid flakyness.
     function(inAppId) {
       appId = inAppId;
       callRemoteTestUtil('resizeWindow',
                          appId,
                          [320, 320],
                          this.next);
     },
     // Select the image.
@@ skipping 37 matching lines @@
  * Tests if the audio player shows up for the selected image and that the audio
  * is loaded successfully.
  *
  * @param {string} path Directory path to be tested.
  */
 testcase.intermediate.audioOpen = function(path) {
   var appId;
   var audioAppId;
   StepsRunner.run([
     function() {
-      var appState = {currentDirectoryPath: path};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, path, this.next);
     },
     // Select the song.
     function(inAppId) {
       appId = inAppId;
       callRemoteTestUtil(
           'openFile', appId, ['Beautiful Song.ogg'], this.next);
     },
     // Wait for the audio player.
     function(result) {
       chrome.test.assertTrue(result);
@@ skipping 41 matching lines @@
  * Tests if the video player shows up for the selected movie and that it is
  * loaded successfully.
  *
  * @param {string} path Directory path to be tested.
  */
 testcase.intermediate.videoOpen = function(path) {
   var appId;
   var videoAppId;
   StepsRunner.run([
     function() {
-      var appState = {currentDirectoryPath: path};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, path, this.next);
     },
     function(inAppId) {
       appId = inAppId;
       // Select the song.
       callRemoteTestUtil(
           'openFile', appId, ['world.ogv'], this.next);
     },
     function(result) {
       chrome.test.assertTrue(result);
       // Wait for the video player.
@@ skipping 39 matching lines @@
   var expectedFilesBefore =
       TestEntryInfo.getExpectedRows(path == '/drive/root' ?
           BASIC_DRIVE_ENTRY_SET : BASIC_LOCAL_ENTRY_SET).sort();
   var expectedFilesAfter =
       expectedFilesBefore.concat([['world (1).ogv', '59 KB', 'OGG video']]);
 
   var appId, fileListBefore;
   StepsRunner.run([
     // Set up File Manager.
     function() {
-      var appState = {currentDirectoryPath: path};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, path, this.next);
     },
     // Copy the file.
     function(inAppId, inFileListBefore) {
       appId = inAppId;
       fileListBefore = inFileListBefore;
       chrome.test.assertEq(expectedFilesBefore, inFileListBefore);
       callRemoteTestUtil('copyFile', appId, [filename], this.next);
     },
     // Wait for a file list change.
     function(result) {
@@ skipping 24 matching lines @@
     }
     return false;
   };
 
   var filename = 'world.ogv';
   var directoryName = 'photos';
   var appId, fileListBefore;
   StepsRunner.run([
     // Set up File Manager.
     function() {
-      var appState = {currentDirectoryPath: path};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, path, this.next);
     },
     // Delete the file.
     function(inAppId, inFileListBefore) {
       appId = inAppId;
       fileListBefore = inFileListBefore;
       chrome.test.assertTrue(isFilePresent(filename, fileListBefore));
       callRemoteTestUtil(
           'deleteFile', appId, [filename], this.next);
     },
     // Reply to a dialog.
@@ skipping 85 matching lines @@
 /**
  * Tests opening the "Recent" on the sidebar navigation by clicking the icon,
  * and verifies the directory contents. We test if there are only files, since
  * directories are not allowed in "Recent". This test is only available for
  * Drive.
  */
 testcase.openSidebarRecent = function() {
   var appId;
   StepsRunner.run([
     function() {
-      var appState = {currentDirectoryPath: '/drive/root'};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, '/drive/root', this.next);
     },
     // Click the icon of the Recent volume.
     function(inAppId) {
       appId = inAppId;
       callRemoteTestUtil(
         'selectVolume', appId, ['drive_recent'], this.next);
     },
     // Wait until the file list is updated.
     function(result) {
       chrome.test.assertFalse(!result);
@@ skipping 16 matching lines @@
 /**
  * Tests opening the "Offline" on the sidebar navigation by clicking the icon,
  * and checks contenets of the file list. Only the entries "available offline"
  * should be shown. "Available offline" entires are hosted documents and the
  * entries cached by DriveCache.
  */
 testcase.openSidebarOffline = function() {
   var appId;
   StepsRunner.run([
     function() {
-      var appState = {currentDirectoryPath: '/drive/root/'};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, '/drive/root', this.next);
     },
     // Click the icon of the Offline volume.
     function(inAppId) {
       appId = inAppId;
       callRemoteTestUtil(
         'selectVolume', appId, ['drive_offline'], this.next);
     },
     // Wait until the file list is updated.
     function(result) {
       chrome.test.assertFalse(!result);
@@ skipping 15 matching lines @@
 
 /**
  * Tests opening the "Shared with me" on the sidebar navigation by clicking the
  * icon, and checks contents of the file list. Only the entries labeled with
  * "shared-with-me" should be shown.
  */
 testcase.openSidebarSharedWithMe = function() {
   var appId;
   StepsRunner.run([
     function() {
-      var appState = {currentDirectoryPath: '/drive/root/'};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, '/drive/root', this.next);
     },
     // Click the icon of the Shared With Me volume.
     function(inAppId) {
       appId = inAppId;
       // Use the icon for a click target.
       callRemoteTestUtil('selectVolume',
                          appId,
                          ['drive_shared_with_me'], this.next);
     },
     // Wait until the file list is updated.
@@ skipping 20 matching lines @@
  * Drive.
  */
 testcase.autocomplete = function() {
   var EXPECTED_AUTOCOMPLETE_LIST = [
     '\'hello\' - search Drive\n',
     'hello.txt\n',
   ];
 
   StepsRunner.run([
     function() {
-      var appState = {currentDirectoryPath: '/drive/root'};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, '/drive/root', this.next);
     },
     // Perform an auto complete test and wait until the list changes.
     // TODO(mtomasz): Move the operation from test_util.js to tests_cases.js.
     function(appId, list) {
       callRemoteTestUtil('performAutocompleteAndWait',
                          appId,
                          ['hello', EXPECTED_AUTOCOMPLETE_LIST.length],
                          this.next);
     },
     // Verify the list contents.
@@ skipping 20 matching lines @@
                                                     srcEntries,
                                                     dstName,
                                                     dstEntries) {
   var srcContents = TestEntryInfo.getExpectedRows(srcEntries).sort();
   var dstContents = TestEntryInfo.getExpectedRows(dstEntries).sort();
 
   var appId;
   StepsRunner.run([
     // Set up File Manager.
     function() {
-      var appState = {currentDirectoryPath: '/Downloads'};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, '/Downloads', this.next);
     },
     // Select the source volume.
     function(inAppId) {
       appId = inAppId;
       callRemoteTestUtil(
           'selectVolume', appId, [srcName], this.next);
     },
     // Wait for the expected files to appear in the file list.
     function(result) {
       chrome.test.assertTrue(result);
@@ skipping 76 matching lines @@
 
 /**
  * Test sharing dialog for a file or directory on Drive
  * @param {string} path Path for a file or a directory to be shared.
  */
 testcase.intermediate.share = function(path) {
   var appId;
   StepsRunner.run([
     // Set up File Manager.
     function() {
-      var appState = {currentDirectoryPath: '/drive/root/'};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, '/drive/root', this.next);
     },
     // Select the source file.
     function(inAppId) {
       appId = inAppId;
       callRemoteTestUtil(
           'selectFile', appId, [path], this.next);
     },
     // Wait for the share button.
     function(result) {
       chrome.test.assertTrue(result);
@@ skipping 50 matching lines @@
     },
     // Check for Javascript errros.
     function() {
       checkIfNoErrorsOccured(this.next);
     }
   ]);
 };
 
 /**
  * Test utility for traverse tests.
+ * @param {string} path Root path to be traversed.
  */
-testcase.intermediate.traverseDirectories = function(root) {
+testcase.intermediate.traverseDirectories = function(path) {
   var appId;
   StepsRunner.run([
-    // Set up File Manager.
+    // Set up File Manager. Do not add initial files.
     function() {
-      var appState = {currentDirectoryPath: root};
-      callRemoteTestUtil('openMainWindow', null, [appState], this.next);
+      openNewWindow(null, path, this.next);
     },
     // Check the initial view.
     function(inAppId) {
       appId = inAppId;
       addEntries(['local', 'drive'], NESTED_ENTRY_SET, this.next);
     },
     function(result) {
       chrome.test.assertTrue(result);
       callRemoteTestUtil('waitForFiles',
                          appId,
@@ skipping 136 matching lines @@
 testcase.executeDefaultTaskOnDrive = function(root) {
   testcase.intermediate.executeDefaultTask(true);
 };
 
 testcase.executeDefaultTaskOnDownloads = function(root) {
   testcase.intermediate.executeDefaultTask(false);
 };
 
 /**
  * Tests executing the default task when there is only one task.
+ * @param {boolean} drive Whether to test Drive or Downloads.
  */
 testcase.intermediate.executeDefaultTask = function(drive) {
-  var root = drive ? '/drive/root' : '/Downloads';
+  var path = drive ? '/drive/root' : '/Downloads';
   var taskId = drive ? 'dummytaskid|drive|open-with' : 'dummytaskid|open-with'
   var appId;
   StepsRunner.run([
     // Set up File Manager.
     function() {
-      var appState = {
-        currentDirectoryPath: root
-      };
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, path, this.next);
     },
     // Override tasks list with a dummy task.
     function(inAppId, inFileListBefore) {
       appId = inAppId;
 
       callRemoteTestUtil(
           'overrideTasks',
           appId,
           [[
             {
@@ skipping 47 matching lines @@
     function() {
       chrome.test.sendMessage(
           JSON.stringify({name: 'getCwsWidgetContainerMockUrl'}),
           this.next);
     },
     // Override the container URL with the mock.
     function(json) {
       var data = JSON.parse(json);
 
       var appState = {
-        currentDirectoryPath: '/drive/root',
         suggestAppsDialogState: {
           overrideCwsContainerUrlForTest: data.url,
           overrideCwsContainerOriginForTest: data.origin
         }
       };
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(appState, '/drive/root', this.next);
     },
     function(inAppId, inFileListBefore) {
       appId = inAppId;
 
       callRemoteTestUtil(
           'selectFile', appId, ['unsupported.foo'], this.next);
     },
     // Double-click the file.
     function(result) {
       chrome.test.assertTrue(result);
@@ skipping 87 matching lines @@
 };
 
 /**
  * Tests hiding the search box.
  */
 testcase.hideSearchBox = function() {
   var appId;
   StepsRunner.run([
     // Set up File Manager.
     function() {
-      var appState = {currentDirectoryPath: '/Downloads'};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, '/Downloads', this.next);
     },
     // Resize the window.
     function(inAppId, inFileListBefore) {
       appId = inAppId;
       callRemoteTestUtil('resizeWindow', appId, [100, 100], this.next);
     },
     // Wait for the style change.
     function(result) {
       chrome.test.assertTrue(result);
       callRemoteTestUtil('waitForStyles',
@@ skipping 19 matching lines @@
   var EXPECTED_FILES = TestEntryInfo.getExpectedRows([
     ENTRIES.world,
     ENTRIES.photos,
     ENTRIES.desktop,
     ENTRIES.hello,
     ENTRIES.beautiful
   ]);
   StepsRunner.run([
     // Set up File Manager.
     function() {
-      var appState = {currentDirectoryPath: '/Downloads'};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, '/Downloads', this.next);
     },
     // Sort by name.
     function(inAppId) {
       appId = inAppId;
       callRemoteTestUtil('fakeMouseClick',
                          appId,
                          ['.table-header-cell:nth-of-type(1)'],
                          this.next);
     },
     // Check the sorted style of the header.
@@ skipping 19 matching lines @@
     },
     // Check the sorted files.
     function() {
       callRemoteTestUtil('waitForFiles',
                          appId,
                          [EXPECTED_FILES, {orderCheck: true}],
                          this.next);
     },
     // Open another window, where the sorted column should be restored.
     function() {
-      var appState = {currentDirectoryPath: '/Downloads'};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, '/Downloads', this.next);
     },
     // Check the sorted style of the header.
     function(inAppId) {
       appId = inAppId;
       callRemoteTestUtil('waitForElement',
                          appId,
                          ['.table-header-sort-image-desc'],
                          this.next);
     },
     // Check the sorted files.
@@ skipping 11 matching lines @@
 };
 
 /**
  * Tests restoring the current view (the file list or the thumbnail grid).
  */
 testcase.restoreCurrentView = function() {
   var appId;
   StepsRunner.run([
     // Set up File Manager.
     function() {
-      var appState = {currentDirectoryPath: '/Downloads'};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, '/Downloads', this.next);
     },
     // Check the initial view.
     function(inAppId) {
       appId = inAppId;
       callRemoteTestUtil('waitForElement',
                          appId,
                          ['.thumbnail-grid[hidden]'],
                          this.next);
     },
     // Opens the gear menu.
@@ skipping 13 matching lines @@
     // Check the new current view.
     function(result) {
       chrome.test.assertTrue(result);
       callRemoteTestUtil('waitForElement',
                          appId,
                          ['.detail-table[hidden]'],
                          this.next);
     },
     // Open another window, where the current view is restored.
     function() {
-      var appState = {currentDirectoryPath: '/Downloads'};
-      callRemoteTestUtil('openMainWindow', null, [appState], this.next);
+      openNewWindow(null, '/Downloads', this.next);
     },
     // Check the current view.
     function(inAppId) {
       appId = inAppId;
       callRemoteTestUtil('waitForElement',
                          appId,
                          ['.detail-table[hidden]'],
                          this.next);
     },
     // Check the error.
     function() {
       checkIfNoErrorsOccured(this.next);
     }
   ]);
 };
 
 /**
  * Tests keyboard operations of the navigation list.
  */
 testcase.traverseNavigationList = function() {
   var appId;
   StepsRunner.run([
     // Set up File Manager.
     function() {
-      var appState = {currentDirectoryPath: '/drive/root'};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, '/drive/root', this.next);
     },
     // Wait until Google Drive is selected.
     function(inAppId) {
       appId = inAppId;
       callRemoteTestUtil(
           'waitForElement',
           appId,
           ['#navigation-list > .root-item > ' +
                '.volume-icon[volume-type-icon="drive"]'],
           this.next);
@@ skipping 74 matching lines @@
 
 /**
  * Tests restoring geometry of the Files app.
  */
 testcase.restoreGeometry = function() {
   var appId;
   var appId2;
   StepsRunner.run([
     // Set up File Manager.
     function() {
-      var appState = {currentDirectoryPath: '/Downloads'};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, '/Downloads', this.next);
     },
     // Resize the window to minimal dimensions.
     function(inAppId) {
       appId = inAppId;
       callRemoteTestUtil(
           'resizeWindow', appId, [640, 480], this.next);
     },
     // Check the current window's size.
     function(inAppId) {
       callRemoteTestUtil('waitForWindowGeometry',
                          appId,
                          [640, 480],
                          this.next);
     },
     // Enlarge the window by 10 pixels.
     function(result) {
       callRemoteTestUtil(
           'resizeWindow', appId, [650, 490], this.next);
     },
     // Check the current window's size.
     function() {
       callRemoteTestUtil('waitForWindowGeometry',
                          appId,
                          [650, 490],
                          this.next);
     },
     // Open another window, where the current view is restored.
     function() {
-      var appState = {currentDirectoryPath: '/Downloads'};
-      setupAndWaitUntilReady(appState, this.next);
+      openNewWindow(null, '/Downloads', this.next);
     },
     // Check the next window's size.
     function(inAppId) {
       appId2 = inAppId;
       callRemoteTestUtil('waitForWindowGeometry',
                          appId2,
                          [650, 490],
                          this.next);
     },
     // Check for errors.
@@ skipping 16 matching lines @@
     testcase.intermediate.traverseDirectories.bind(null, '/drive/root');
 
 /**
  * Tests the focus behavior of the search box.
  */
 testcase.searchBoxFocus = function() {
   var appId;
   StepsRunner.run([
     // Set up File Manager.
     function() {
-      var appState = {currentDirectoryPath: '/drive/root'};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, '/drive/root', this.next);
     },
     // Check that the file list has the focus on launch.
     function(inAppId) {
       appId = inAppId;
       callRemoteTestUtil(
           'waitForElement', appId, ['#file-list:focus'], this.next);
     },
     // Press the Ctrl-F key.
     function(element) {
       callRemoteTestUtil('fakeKeyDown',
@@ skipping 28 matching lines @@
 };
 
 /**
  * Tests if a thumbnail for the selected item shows up in the preview panel.
  * This thumbnail is fetched via the image loader.
  */
 testcase.thumbnailsDownloads = function() {
   var appId;
   StepsRunner.run([
     function() {
-      var appState = {currentDirectoryPath: '/Downloads'};
-      setupAndWaitUntilReady(appState, this.next);
+      setupAndWaitUntilReady(null, '/Downloads', this.next);
     },
     // Select the image.
     function(inAppId) {
       appId = inAppId;
       callRemoteTestUtil('selectFile',
                          appId,
                          ['My Desktop Background.png'],
                          this.next);
     },
     // Wait until the thumbnail shows up.
     function(result) {
       chrome.test.assertTrue(result);
       callRemoteTestUtil('waitForElement',
                          appId,
                          ['.preview-thumbnails .img-container img'],
                          this.next);
     },
     // Verify the thumbnail.
     function(element) {
       chrome.test.assertTrue(element.attributes.src.indexOf(
           'data:image/jpeg') === 0);
       checkIfNoErrorsOccured(this.next);
     }
   ]);
 };