Migrate fullPaths to URLs in appState.
This patch replaces currentDirectoryPath with currentDirectoryURL, and same for the selectionPath. As a result, the entire appState does not depend on paths anymore.
TEST=browser_tests, also tested manually.
BUG=333168
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247855
6 years, 11 months ago
(2014-01-27 06:31:33 UTC)
#4
lgtm! Thanks!
mtomasz
On 2014/01/27 06:31:33, hirono wrote: > lgtm! Thanks! I've rebased the CL. @sky: PTAL at ...
6 years, 10 months ago
(2014-01-29 02:57:01 UTC)
#5
On 2014/01/27 06:31:33, hirono wrote:
> lgtm! Thanks!
I've rebased the CL.
@sky: PTAL at select_file_dialog_extension.cc
@hirono: PTAL one more time.
Thanks.
hirono
On 2014/01/29 02:57:01, mtomasz wrote: > On 2014/01/27 06:31:33, hirono wrote: > > lgtm! Thanks! ...
6 years, 10 months ago
(2014-01-29 06:02:59 UTC)
#6
On 2014/01/29 02:57:01, mtomasz wrote:
> On 2014/01/27 06:31:33, hirono wrote:
> > lgtm! Thanks!
>
> I've rebased the CL.
>
> @sky: PTAL at select_file_dialog_extension.cc
> @hirono: PTAL one more time.
>
> Thanks.
still lgtm!
sky
LGTM
6 years, 10 months ago
(2014-01-29 17:27:54 UTC)
#7
LGTM
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/132453007/320001
6 years, 10 months ago
(2014-01-29 22:59:11 UTC)
#8
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=144418
6 years, 10 months ago
(2014-01-30 00:17:33 UTC)
#9
Issue 132453007: Migrate fullPaths to URLs in appState.
(Closed)
Created 6 years, 11 months ago by mtomasz
Modified 6 years, 10 months ago
Reviewers: hirono, sky
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 6