Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 132453007: Migrate fullPaths to URLs in appState. (Closed)

Created:
6 years, 11 months ago by mtomasz
Modified:
6 years, 10 months ago
Reviewers:
hirono, sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Migrate fullPaths to URLs in appState. This patch replaces currentDirectoryPath with currentDirectoryURL, and same for the selectionPath. As a result, the entire appState does not depend on paths anymore. TEST=browser_tests, also tested manually. BUG=333168 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247855

Patch Set 1 #

Total comments: 6

Patch Set 2 : One more fix. #

Patch Set 3 : Cleaned up. #

Patch Set 4 : Rebased. #

Patch Set 5 : Rebased. #

Patch Set 6 : Cleaned up. #

Patch Set 7 : Rebased. #

Messages

Total messages: 11 (0 generated)
mtomasz
@hirono: PTAL. Thanks!
6 years, 11 months ago (2014-01-27 05:16:16 UTC) #1
hirono
https://codereview.chromium.org/132453007/diff/1/chrome/browser/resources/file_manager/background/js/background.js File chrome/browser/resources/file_manager/background/js/background.js (right): https://codereview.chromium.org/132453007/diff/1/chrome/browser/resources/file_manager/background/js/background.js#newcode536 chrome/browser/resources/file_manager/background/js/background.js:536: contentWindow.appState.currentDirectoryPath) { currentDirectoryURL? https://codereview.chromium.org/132453007/diff/1/chrome/browser/resources/file_manager/background/js/background.js#newcode784 chrome/browser/resources/file_manager/background/js/background.js:784: currentDirectoryPath: background.appWindows[key].contentWindow. ditto. https://codereview.chromium.org/132453007/diff/1/chrome/browser/resources/file_manager/foreground/js/file_manager_commands.js ...
6 years, 11 months ago (2014-01-27 05:39:56 UTC) #2
mtomasz
https://codereview.chromium.org/132453007/diff/1/chrome/browser/resources/file_manager/background/js/background.js File chrome/browser/resources/file_manager/background/js/background.js (right): https://codereview.chromium.org/132453007/diff/1/chrome/browser/resources/file_manager/background/js/background.js#newcode536 chrome/browser/resources/file_manager/background/js/background.js:536: contentWindow.appState.currentDirectoryPath) { On 2014/01/27 05:39:56, hirono wrote: > currentDirectoryURL? ...
6 years, 11 months ago (2014-01-27 06:12:52 UTC) #3
hirono
lgtm! Thanks!
6 years, 11 months ago (2014-01-27 06:31:33 UTC) #4
mtomasz
On 2014/01/27 06:31:33, hirono wrote: > lgtm! Thanks! I've rebased the CL. @sky: PTAL at ...
6 years, 10 months ago (2014-01-29 02:57:01 UTC) #5
hirono
On 2014/01/29 02:57:01, mtomasz wrote: > On 2014/01/27 06:31:33, hirono wrote: > > lgtm! Thanks! ...
6 years, 10 months ago (2014-01-29 06:02:59 UTC) #6
sky
LGTM
6 years, 10 months ago (2014-01-29 17:27:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/132453007/320001
6 years, 10 months ago (2014-01-29 22:59:11 UTC) #8
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=144418
6 years, 10 months ago (2014-01-30 00:17:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/132453007/320001
6 years, 10 months ago (2014-01-30 00:28:24 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 06:41:14 UTC) #11
Message was sent while issue was closed.
Change committed as 247855

Powered by Google App Engine
This is Rietveld 408576698