Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: chrome/browser/profiles/avatar_menu.cc

Issue 132453004: Add Profile metric counting to new User Manager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more mac compilation fixes Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/avatar_menu.cc
diff --git a/chrome/browser/profiles/avatar_menu.cc b/chrome/browser/profiles/avatar_menu.cc
index f3db24a0f926732401414ec927d612e16df7b7c6..8ba3d15a51e3bc4be5bc5aa669e1689f157c29bd 100644
--- a/chrome/browser/profiles/avatar_menu.cc
+++ b/chrome/browser/profiles/avatar_menu.cc
@@ -115,7 +115,8 @@ bool AvatarMenu::CompareItems(const Item* item1, const Item* item2) {
base::i18n::ToLower(item2->name)) < 0;
}
-void AvatarMenu::SwitchToProfile(size_t index, bool always_create) {
+void AvatarMenu::SwitchToProfile(
+ size_t index, bool always_create, ProfileMetrics::ProfileOpen metric) {
Alexei Svitkine (slow) 2014/01/28 16:25:31 If you wrap params, it should be 1 per line.
bcwhite 2014/01/28 17:03:03 Done.
DCHECK(profiles::IsMultipleProfilesEnabled() ||
index == GetActiveProfileIndex());
const Item& item = GetItemAt(index);
@@ -136,8 +137,8 @@ void AvatarMenu::SwitchToProfile(size_t index, bool always_create) {
desktop_type = browser_->host_desktop_type();
profiles::SwitchToProfile(path, desktop_type, always_create,
- profiles::ProfileSwitchingDoneCallback());
- ProfileMetrics::LogProfileSwitchUser(ProfileMetrics::SWITCH_PROFILE_ICON);
+ profiles::ProfileSwitchingDoneCallback(),
+ metric);
}
void AvatarMenu::AddNewProfile(ProfileMetrics::ProfileAdd type) {

Powered by Google App Engine
This is Rietveld 408576698