Issue 132453002: Moves CandidateWindow model to ui/base/ime (2nd)

Issue 132453002: Moves CandidateWindow model to ui/base/ime (2nd) (Closed)

Created:
6 years, 11 months ago by Jun Mukai

Modified:
6 years, 11 months ago

Reviewers:
Hiro Komatsu

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Moves CandidateWindow model to ui/base/ime (2nd) The previous cl was reverted due to a missing edit to a new file introduced right before my commit. BUG=325813 TBR=komatsu@chromium.org TEST=build passes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244007

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+128 lines, -477 lines)			Patch
M	chrome/browser/chromeos/input_method/candidate_view.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_view.cc	View	10 chunks	+15 lines, -14 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window_controller_impl.h	View	3 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc	View	4 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window_controller_impl_unittest.cc	View	4 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window_view.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window_view.cc	View	7 chunks	+11 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc	View	12 chunks	+26 lines, -25 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_engine.h	View	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_engine.cc	View	5 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc	View	7 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/mock_input_method_engine.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/chromeos.gyp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
D	chromeos/ime/candidate_window.h	View	1 chunk	+0 lines, -127 lines	0 comments	Download
D	chromeos/ime/candidate_window.cc	View	1 chunk	+0 lines, -78 lines	0 comments	Download
D	chromeos/ime/candidate_window_unittest.cc	View	1 chunk	+0 lines, -140 lines	0 comments	Download
A +	ui/base/ime/candidate_window.h	View	3 chunks	+10 lines, -12 lines	0 comments	Download
A +	ui/base/ime/candidate_window.cc	View	2 chunks	+4 lines, -6 lines	0 comments	Download
A +	ui/base/ime/candidate_window_unittest.cc	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	ui/base/ime/chromeos/ibus_bridge.h	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	ui/base/ime/chromeos/mock_ime_candidate_window_handler.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/base/ime/chromeos/mock_ime_candidate_window_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/ime/ime.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/base/ime/ime_unittests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/132453002/1

6 years, 11 months ago (2014-01-09 19:27:38 UTC) #1

Message was sent while issue was closed.

Change committed as 244007

Expand Messages | Collapse Messages