Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1324523004: Revert of [sqlite] Respect the gyp and gn component switch. (Closed)

Created:
5 years, 3 months ago by sergeyv
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [sqlite] Respect the gyp and gn component switch. (patchset #1 id:1 of https://codereview.chromium.org/1322463002/ ) Reason for revert: Broken build on the Builder: Win x64 GN (dbg). Failure example: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/8549 Original issue's description: > [sqlite] Respect the gyp and gn component switch. > > SQLITE_API is the existing mechanism SQLite provides, and is used in > preference to inventing a new SQLITE_EXPORT symbol (like > sql/sql_export.h and other examples). > > CoreServices.framework is necessary on OSX because of the Time Machine > patch. > > Remove sql/proxy.{h,cc}, which was necessary to work around SQLite > linking statically into both component shlibs and unit test executables. > > BUG=489444 > > Committed: https://crrev.com/4ec68d9ad2d3e0c74967a17946c8bf7ed4450f73 > Cr-Commit-Position: refs/heads/master@{#346151} TBR=michaeln@chromium.org,shess@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=489444 Committed: https://crrev.com/b5feb9e34aae49aff54212f4848a8cb51b3537e0 Cr-Commit-Position: refs/heads/master@{#346179}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -35 lines) Patch
M sql/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M sql/connection_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
A sql/proxy.h View 1 chunk +39 lines, -0 lines 0 comments Download
A sql/proxy.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M sql/sql.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/sqlite/BUILD.gn View 3 chunks +1 line, -18 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 3 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sergeyv
Created Revert of [sqlite] Respect the gyp and gn component switch.
5 years, 3 months ago (2015-08-28 17:46:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324523004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324523004/1
5 years, 3 months ago (2015-08-28 17:47:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 17:48:12 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b5feb9e34aae49aff54212f4848a8cb51b3537e0 Cr-Commit-Position: refs/heads/master@{#346179}
5 years, 3 months ago (2015-08-28 17:48:47 UTC) #4
Scott Hess - ex-Googler
5 years, 3 months ago (2015-08-28 17:51:02 UTC) #5
Message was sent while issue was closed.
darn, I was just about to land the fix!

np, I can just slipstream it.  since the gn bots were FYI, it was ambiguous
whether to immediately revert or quickly patch.

Powered by Google App Engine
This is Rietveld 408576698