Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1324483002: Native context: install array methods via runtime import. (Closed)

Created:
5 years, 3 months ago by Yang
Modified:
5 years, 3 months ago
Reviewers:
Camillo Bruni
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Native context: install array methods via runtime import. R=cbruni@chromium.org Committed: https://crrev.com/08ee2132a818a0178038afa521ca06c297195cc9 Cr-Commit-Position: refs/heads/master@{#30446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -188 lines) Patch
M src/array.js View 5 chunks +50 lines, -45 lines 0 comments Download
M src/bootstrapper.cc View 23 chunks +104 lines, -113 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Yang
Please review.
5 years, 3 months ago (2015-08-28 11:34:56 UTC) #1
Camillo Bruni
lgtm
5 years, 3 months ago (2015-08-28 12:31:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324483002/1
5 years, 3 months ago (2015-08-28 12:53:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 13:39:39 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/08ee2132a818a0178038afa521ca06c297195cc9 Cr-Commit-Position: refs/heads/master@{#30446}
5 years, 3 months ago (2015-08-28 13:39:55 UTC) #6
Michael Achenbach
5 years, 3 months ago (2015-08-31 10:09:35 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1314193003/ by machenbach@chromium.org.

The reason for reverting is: This breaks builds without i18n support. Bisected
locally. See builder:

http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20...

http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20...

# Fatal error in .././src/objects-inl.h, line 1381
# Check failed: READ_FIELD(this, offset)->IsSmi()..

Powered by Google App Engine
This is Rietveld 408576698