Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: skia/ext/SkTraceMemoryDump_chrome.h

Issue 1324453008: Implement the getRequestDetails api in chrome side. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@skia_expose
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/web_process_memory_dump_impl.cc ('k') | skia/ext/SkTraceMemoryDump_chrome.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/ext/SkTraceMemoryDump_chrome.h
diff --git a/skia/ext/SkTraceMemoryDump_chrome.h b/skia/ext/SkTraceMemoryDump_chrome.h
index 749d99d54677aa6ddbd40dddf1b82e26eaeee53d..aa4bf5122d3d1901b7b74588d20476b73dd5ec15 100644
--- a/skia/ext/SkTraceMemoryDump_chrome.h
+++ b/skia/ext/SkTraceMemoryDump_chrome.h
@@ -8,12 +8,12 @@
#include <string>
#include "base/macros.h"
+#include "base/trace_event/memory_dump_provider.h"
#include "third_party/skia/include/core/SkTraceMemoryDump.h"
namespace base {
namespace trace_event {
class MemoryAllocatorDump;
-class ProcessMemoryDump;
}
}
@@ -26,10 +26,12 @@ class SkTraceMemoryDump_Chrome : public SkTraceMemoryDump {
// |dump_name_prefix| argument specifies the prefix appended to the dump
// name skia provides. By default it is taken as empty string.
SkTraceMemoryDump_Chrome(
+ const base::trace_event::MemoryDumpArgs& args,
Primiano Tucci (use gerrit) 2015/09/09 17:27:23 why don't you pass just the "LevelOfDetail" enum h
base::trace_event::ProcessMemoryDump* process_memory_dump);
SkTraceMemoryDump_Chrome(
const char* dump_name_prefix,
+ const base::trace_event::MemoryDumpArgs& args,
base::trace_event::ProcessMemoryDump* process_memory_dump);
~SkTraceMemoryDump_Chrome() override;
@@ -45,6 +47,7 @@ class SkTraceMemoryDump_Chrome : public SkTraceMemoryDump {
void setDiscardableMemoryBacking(
const char* dumpName,
const SkDiscardableMemory& discardableMemoryObject) override;
+ bool isLightDump() const override;
protected:
base::trace_event::ProcessMemoryDump* process_memory_dump() {
@@ -55,6 +58,7 @@ class SkTraceMemoryDump_Chrome : public SkTraceMemoryDump {
std::string dump_name_prefix_;
base::trace_event::ProcessMemoryDump* process_memory_dump_;
+ bool is_light_dump_;
// Helper to create allocator dumps.
base::trace_event::MemoryAllocatorDump* GetOrCreateAllocatorDump(
« no previous file with comments | « content/child/web_process_memory_dump_impl.cc ('k') | skia/ext/SkTraceMemoryDump_chrome.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698