Implement the getRequestDetails api in chrome side.

Implement the IsLightDump api in chrome side.

This implements new SkTraceMemoryDump interface changed in
www.crrev.com/1310123007.

The dump manager in base decides to request a heavy or light dump
depending on the user's configurations. The light dumps are more
frequent than heavy ones, but has onl the totals from the dump
providers. This is to enure that the trace is not huge as well as the
dumps are frequent enough in the traces. This change passes the dump
args that is provided on OnMemoryDump call to the SkTraceMemoryDump
object, which implements RequestDetails method.
The discardable details are enabled always for consistency across
dumps.

It also changes the argument in constructor to string from char* since
it is not cler if the constructor stores it or copies it.

TBR=reveman@chromium.org
BUG=499731
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/02adde97ae3b52e7ef7f7971d36ceff46654dc1d
Cr-Commit-Position: refs/heads/master@{#351541}

[ssid, 2015-09-07 19:04:25]

ssid@chromium.org changed reviewers:
+ primiano@chromium.org

[ssid, 2015-09-07 19:04:25]

PTAL, thanks

[Primiano Tucci (use gerrit), 2015-09-09 17:27:23]

LGTM with 1 comment

https://codereview.chromium.org/1324453008/diff/1/skia/ext/SkTraceMemoryDump_...
File skia/ext/SkTraceMemoryDump_chrome.h (right):

https://codereview.chromium.org/1324453008/diff/1/skia/ext/SkTraceMemoryDump_...
skia/ext/SkTraceMemoryDump_chrome.h:29: const base::trace_event::MemoryDumpArgs&
args,
why don't you pass just the "LevelOfDetail" enum here. It would be clearer

[ssid, 2015-09-10 11:08:58]

Fixed the args and the string.

[ssid, 2015-09-10 11:23:15]

ssid@chromium.org changed reviewers:
+ reed@google.com

[ssid, 2015-09-10 11:23:16]

+reed, PTAL thanks.

[reed1, 2015-09-10 17:01:30]

This sort of impl change is pretty opaque to me, but lgtm.

[Primiano Tucci (use gerrit), 2015-09-10 17:19:35]

On 2015/09/10 17:01:30, reed1 wrote:
> This sort of impl change is pretty opaque to me, but lgtm.

Yeah, speaking about which, the commit message could be a bit more explicative.
ssid: mind expanding that and giving a brief explanation there of what is a
light dump?

[ssid, 2015-09-10 19:29:47]

On 2015/09/10 17:19:35, Primiano Tucci wrote:
> On 2015/09/10 17:01:30, reed1 wrote:
> > This sort of impl change is pretty opaque to me, but lgtm.
> 
> Yeah, speaking about which, the commit message could be a bit more
explicative.
> ssid: mind expanding that and giving a brief explanation there of what is a
> light dump?

I have updated the CL description. If you would like to know more about what the
other components do for light dumps please see the doc
:https://docs.google.com/document/d/19D2XI-4zdH2zFXzNmrMSek5GvvjZSPjp_Z9yI9bLsoA/edit

Thanks, 
Sid.

[ssid, 2015-09-11 15:13:02]

Made changes for the interface change.

[ssid, 2015-09-29 21:49:55]

Patchset #8 (id:140001) has been deleted

[ssid, 2015-09-29 22:12:02]

Patchset #10 (id:200001) has been deleted

[ssid, 2015-09-29 22:12:58]

Patchset #7 (id:120001) has been deleted

[ssid, 2015-09-29 22:13:29]

Patchset #6 (id:100001) has been deleted

[ssid, 2015-09-29 22:14:06]

Patchset #3 (id:40001) has been deleted

[ssid, 2015-09-29 23:05:57]

Patchset #8 (id:240001) has been deleted

[ssid, 2015-09-29 23:09:48]

Patchset #8 (id:260001) has been deleted

[ssid, 2015-09-29 23:10:41]

Patchset #4 (id:80001) has been deleted

[Primiano Tucci (use gerrit), 2015-09-30 08:47:18]

On 2015/09/11 15:13:02, ssid wrote:
> Made changes for the interface change.

LGTM from my side, but make sure that reed and ericrk are fine with this.

[ssid, 2015-09-30 11:33:41]

On 2015/09/30 08:47:18, Primiano Tucci wrote:
> On 2015/09/11 15:13:02, ssid wrote:
> > Made changes for the interface change.
> 
> LGTM from my side, but make sure that reed and ericrk are fine with this.

TBRing reveman@ for changing the skia dumper impl in cc/ file. Will update with
actual light dump support later.

[ssid, 2015-09-30 12:37:56]

The CQ bit was checked by ssid@chromium.org

[ssid, 2015-09-30 12:37:56]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com,
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/1324453008/#ps320001
(title: "Using correct hash.")

[commit-bot: I haz the power, 2015-09-30 12:38:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1324453008/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1324453008/320001

[commit-bot: I haz the power, 2015-09-30 13:13:23]

Committed patchset #9 (id:320001)

[commit-bot: I haz the power, 2015-09-30 13:14:34]

Patchset 9 (id:??) landed as
https://crrev.com/02adde97ae3b52e7ef7f7971d36ceff46654dc1d
Cr-Commit-Position: refs/heads/master@{#351541}

[ssid, 2016-09-07 03:47:46]

Patchset #3 (id:60001) has been deleted

[ssid, 2016-09-07 03:47:51]

Patchset #4 (id:180001) has been deleted

[ssid, 2016-09-07 03:48:14]

Patchset #4 (id:220001) has been deleted

[ssid, 2016-09-07 03:48:23]

Patchset #4 (id:280001) has been deleted

[ssid, 2016-09-07 03:48:33]

Patchset #4 (id:300001) has been deleted