Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1892)

Issue 1324453005: Convert TabHelper design doc to Markdown. (Closed)

Created:
5 years, 3 months ago by Avi (use Gerrit)
Modified:
5 years, 3 months ago
Reviewers:
nodir, Bons
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert TabHelper design doc to Markdown. This replaces https://www.chromium.org/developers/design-documents/tab-helpers . BUG=none TEST=none Committed: https://crrev.com/a41f7af918712d5891df1a057c8f64214411da6b Cr-Commit-Position: refs/heads/master@{#346444}

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -1 line) Patch
M chrome/browser/ui/tab_helpers.h View 1 chunk +1 line, -1 line 0 comments Download
A docs/tab_helpers.md View 1 1 chunk +119 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324453005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324453005/1
5 years, 3 months ago (2015-08-31 18:41:14 UTC) #2
Avi (use Gerrit)
I personally think it's weird to put docs for individual pieces of Chrome in a ...
5 years, 3 months ago (2015-08-31 18:43:32 UTC) #4
Bons
https://codereview.chromium.org/1324453005/diff/1/docs/tab_helpers.md File docs/tab_helpers.md (right): https://codereview.chromium.org/1324453005/diff/1/docs/tab_helpers.md#newcode18 docs/tab_helpers.md:18: example, if we look at the `TabStripModel`, there are ...
5 years, 3 months ago (2015-08-31 18:50:52 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324453005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324453005/20001
5 years, 3 months ago (2015-08-31 18:56:10 UTC) #7
Avi (use Gerrit)
https://codereview.chromium.org/1324453005/diff/1/docs/tab_helpers.md File docs/tab_helpers.md (right): https://codereview.chromium.org/1324453005/diff/1/docs/tab_helpers.md#newcode18 docs/tab_helpers.md:18: example, if we look at the `TabStripModel`, there are ...
5 years, 3 months ago (2015-08-31 18:58:06 UTC) #8
Bons
On 2015/08/31 18:58:06, Avi wrote: > https://codereview.chromium.org/1324453005/diff/1/docs/tab_helpers.md > File docs/tab_helpers.md (right): > > https://codereview.chromium.org/1324453005/diff/1/docs/tab_helpers.md#newcode18 > ...
5 years, 3 months ago (2015-08-31 18:58:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324453005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324453005/20001
5 years, 3 months ago (2015-08-31 19:06:10 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-31 19:47:05 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 19:48:24 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a41f7af918712d5891df1a057c8f64214411da6b
Cr-Commit-Position: refs/heads/master@{#346444}

Powered by Google App Engine
This is Rietveld 408576698