Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1324453003: X87: [Interpreter] Add support for parameter variables. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Interpreter] Add support for parameter variables. port 5d975694e4d3ecf66716cc5395d4d10c9730f9dd (r30403) original commit message: Adds support for parameters to the BytecodeArrayBuilder and BytecodeGenerator. Parameters are accessed as negative interpreter registers. R=weiliang.lin@intel.com BUG= Committed: https://crrev.com/5c55af556a34312d8c45a004ff596ab8e2d51e91 Cr-Commit-Position: refs/heads/master@{#30440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-08-28 09:31:18 UTC) #1
Weiliang
lgtm
5 years, 3 months ago (2015-08-28 10:33:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324453003/1
5 years, 3 months ago (2015-08-28 10:33:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 11:00:40 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 11:00:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c55af556a34312d8c45a004ff596ab8e2d51e91
Cr-Commit-Position: refs/heads/master@{#30440}

Powered by Google App Engine
This is Rietveld 408576698