Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1324413002: Cleanup setting of 'sysroot' in common.gypi (Closed)

Created:
5 years, 3 months ago by Sam Clegg
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup setting of 'sysroot' in common.gypi 'sysroot' is now set in a single location. This avoids the possibility of accidentally referencing the empty default value and makes the code more consistent/readable. Committed: https://crrev.com/76dc52b09818d45ba4fc3cc6270f4548029dca8c Cr-Commit-Position: refs/heads/master@{#349861}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M build/common.gypi View 1 2 3 4 5 3 chunks +15 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324413002/1
5 years, 3 months ago (2015-09-08 11:09:59 UTC) #2
Sam Clegg
5 years, 3 months ago (2015-09-18 11:23:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324413002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324413002/100001
5 years, 3 months ago (2015-09-18 12:04:37 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-18 13:14:47 UTC) #8
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-18 19:23:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324413002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324413002/100001
5 years, 3 months ago (2015-09-19 08:49:10 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 3 months ago (2015-09-19 08:53:34 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-19 08:54:11 UTC) #13
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/76dc52b09818d45ba4fc3cc6270f4548029dca8c
Cr-Commit-Position: refs/heads/master@{#349861}

Powered by Google App Engine
This is Rietveld 408576698